Issue 14601: Some cleanup in view menu delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14601: Some cleanup in view menu delegate (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

More cleanup for CPoint to gfx::Point This was mostly done within the menu view delegate Made sure all references were changed as well. BUG=2186 (http://crbug.com/2186) TEST=Compiled source and ran tests successfully

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -23 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_manager_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_manager_view.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/views/tabs/tab.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/views/checkbox.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/views/menu_button.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/views/view_menu_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour (USE mhm)

11 years, 9 months ago (2009-03-27 21:39:26 UTC) #2

On 2008/12/16 02:43:19, Mohamed Mansour wrote:
> 
I guess I should close this one as well

Expand Messages | Collapse Messages