Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/views/bookmark_bar_view.h

Issue 14601: Some cleanup in view menu delegate (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_
7 7
8 #include "chrome/browser/bookmarks/bookmark_drag_data.h" 8 #include "chrome/browser/bookmarks/bookmark_drag_data.h"
9 #include "chrome/browser/bookmarks/bookmark_model.h" 9 #include "chrome/browser/bookmarks/bookmark_model.h"
10 #include "chrome/common/slide_animation.h" 10 #include "chrome/common/slide_animation.h"
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 284
285 // Returns the drag operations for the specified button. 285 // Returns the drag operations for the specified button.
286 virtual int GetDragOperations(views::View* sender, int x, int y); 286 virtual int GetDragOperations(views::View* sender, int x, int y);
287 287
288 // ViewMenuDelegate method. 3 types of menus may be shown: 288 // ViewMenuDelegate method. 3 types of menus may be shown:
289 // . the menu allowing the user to choose when the bookmark bar is visible. 289 // . the menu allowing the user to choose when the bookmark bar is visible.
290 // . most recently bookmarked menu 290 // . most recently bookmarked menu
291 // . menu for star groups. 291 // . menu for star groups.
292 // The latter two are handled by a MenuRunner, which builds the appropriate 292 // The latter two are handled by a MenuRunner, which builds the appropriate
293 // menu. 293 // menu.
294 virtual void RunMenu(views::View* view, const CPoint& pt, HWND hwnd); 294 virtual void RunMenu(views::View* view, const gfx::Point& pt, HWND hwnd);
295 295
296 // Invoked when a star entry corresponding to a URL on the bookmark bar is 296 // Invoked when a star entry corresponding to a URL on the bookmark bar is
297 // pressed. Forwards to the PageNavigator to open the URL. 297 // pressed. Forwards to the PageNavigator to open the URL.
298 virtual void ButtonPressed(views::BaseButton* sender); 298 virtual void ButtonPressed(views::BaseButton* sender);
299 299
300 // Invoked for this View, one of the buttons or the 'other' button. Shows the 300 // Invoked for this View, one of the buttons or the 'other' button. Shows the
301 // appropriate context menu. 301 // appropriate context menu.
302 virtual void ShowContextMenu(views::View* source, 302 virtual void ShowContextMenu(views::View* source,
303 int x, 303 int x,
304 int y, 304 int y,
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 // If the bookmark bubble is showing, this is the visible ancestor of the URL. 427 // If the bookmark bubble is showing, this is the visible ancestor of the URL.
428 // The visible ancestor is either the other_bookmarked_button_, 428 // The visible ancestor is either the other_bookmarked_button_,
429 // overflow_button_ or a button on the bar. 429 // overflow_button_ or a button on the bar.
430 views::BaseButton* throbbing_view_; 430 views::BaseButton* throbbing_view_;
431 431
432 DISALLOW_COPY_AND_ASSIGN(BookmarkBarView); 432 DISALLOW_COPY_AND_ASSIGN(BookmarkBarView);
433 }; 433 };
434 434
435 #endif // CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_ 435 #endif // CHROME_BROWSER_VIEWS_BOOKMARK_BAR_VIEW_H_
436 436
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698