Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1460093002: PPC: [turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. Port f6e689cebbd2de36e2b38474f89b1ad37fbfbb0f Original commit message: The TruncateFloat64ToUint64 operator converts a float64 to an uint64 using round-to-zero rounding mode (truncate). If the input value is outside uint64 range, then the result depends on the architecture. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/bc5e7fc335721f05b0c5d184c37b5685ba99ad38 Cr-Commit-Position: refs/heads/master@{#32181}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -20 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 chunk +21 lines, -19 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-19 23:33:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460093002/1
5 years, 1 month ago (2015-11-19 23:33:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 23:52:59 UTC) #5
ahaas
https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h File src/compiler/ppc/instruction-codes-ppc.h (right): https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h#newcode91 src/compiler/ppc/instruction-codes-ppc.h:91: V(PPC_DoubleToUInt64) \ nits: s/PPC_DoubleToUInt64/PPC_DoubleToUint64/ https://codereview.chromium.org/1460093002/diff/1/src/ppc/macro-assembler-ppc.cc File src/ppc/macro-assembler-ppc.cc (right): https://codereview.chromium.org/1460093002/diff/1/src/ppc/macro-assembler-ppc.cc#newcode730 ...
5 years, 1 month ago (2015-11-20 07:45:33 UTC) #6
MTBrandyberry
https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h File src/compiler/ppc/instruction-codes-ppc.h (right): https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h#newcode91 src/compiler/ppc/instruction-codes-ppc.h:91: V(PPC_DoubleToUInt64) \ On 2015/11/20 07:45:33, ahaas wrote: > nits: ...
5 years, 1 month ago (2015-11-20 19:38:23 UTC) #7
michael_dawson
On 2015/11/20 19:38:23, mtbrandyberry wrote: > https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h > File src/compiler/ppc/instruction-codes-ppc.h (right): > > https://codereview.chromium.org/1460093002/diff/1/src/compiler/ppc/instruction-codes-ppc.h#newcode91 > ...
5 years, 1 month ago (2015-11-23 14:26:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460093002/20001
5 years, 1 month ago (2015-11-23 14:37:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 15:03:58 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:04:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc5e7fc335721f05b0c5d184c37b5685ba99ad38
Cr-Commit-Position: refs/heads/master@{#32181}

Powered by Google App Engine
This is Rietveld 408576698