NaCl: Update revision in DEPS, 546ef11 -> b6ec17d

NaCl: Update revision in DEPS, 546ef11 -> b6ec17d

This pulls in the following Native Client changes:

1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
26a11d1: (stichnot@chromium.org) Update revision for PNaCl
3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
Cr-Commit-Position: refs/heads/master@{#360958}

[Roland McGrath, 2015-11-20 00:05:24]

mcgrathr@chromium.org changed reviewers:
+ dpranke@chromium.org, dschuff@chromium.org

[Roland McGrath, 2015-11-20 00:05:25]

PTAL

[Derek Schuff, 2015-11-20 00:05:58]

lgtm

[Dirk Pranke, 2015-11-20 00:08:20]

lgtm

[Roland McGrath, 2015-11-20 00:10:05]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2015-11-20 00:10:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460063003/1

[commit-bot: I haz the power, 2015-11-20 00:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 00:26:13]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)

[Roland McGrath, 2015-11-20 00:31:06]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2015-11-20 00:36:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460063003/1

[commit-bot: I haz the power, 2015-11-20 01:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 01:10:45]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)

[erikchen, 2015-11-20 01:12:15]

On 2015/11/20 01:10:45, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
"""
[33398/33854] CXX newlib_pnacl_nonsfi/obj/base/memory/memory/weak_ptr.o
FAILED: /b/build/goma/gomacc
../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD -MF
newlib_pnacl_nonsfi/obj/sandbox/linux/sandbox_services/syscall_wrappers.o.d
-DNACL_TC_REV=4dbae347415d2448b5418db3439d832b8266893a -DSANDBOX_IMPLEMENTATION
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS
-DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA
-DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
-DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_BACKGROUND=1
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG
-DNVALGRIND -I../../native_client/src/public/linux_syscalls -I../..
-Inewlib_pnacl_nonsfi/gen -fno-strict-aliasing -fcolor-diagnostics
--pnacl-allow-translate -arch x86-32-nonsfi --pnacl-bias=x86-32-nonsfi
--target=i686-unknown-nacl -Wall -Wsign-compare -Wendif-labels
-Wno-missing-field-initializers -Wno-unused-parameter -Werror
-Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-reserved-user-defined-literal -Wno-sign-compare -O2 -fno-ident
-fdata-sections -ffunction-sections -g1 -fvisibility=hidden
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
-fno-exceptions -c ../../sandbox/linux/services/syscall_wrappers.cc -o
newlib_pnacl_nonsfi/obj/sandbox/linux/sandbox_services/syscall_wrappers.o
../../sandbox/linux/services/syscall_wrappers.cc:200:1: error: GNU-style inline
assembly is disabled
asm(
^
1 error generated.
ninja: build stopped: subcommand failed.
"""

[Roland McGrath, 2015-11-20 17:47:11]

On 2015/11/20 01:12:15, erikchen wrote:
> On 2015/11/20 01:10:45, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build
URL)
> 
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
> """
> [33398/33854] CXX newlib_pnacl_nonsfi/obj/base/memory/memory/weak_ptr.o
> FAILED: /b/build/goma/gomacc
> ../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD
-MF
> newlib_pnacl_nonsfi/obj/sandbox/linux/sandbox_services/syscall_wrappers.o.d
> -DNACL_TC_REV=4dbae347415d2448b5418db3439d832b8266893a
-DSANDBOX_IMPLEMENTATION
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS
> -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1
> -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA
> -DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DENABLE_WEBRTC=1
> -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1
> -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SESSION_SERVICE=1
> -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
> -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_BACKGROUND=1
> -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG
> -DNVALGRIND -I../../native_client/src/public/linux_syscalls -I../..
> -Inewlib_pnacl_nonsfi/gen -fno-strict-aliasing -fcolor-diagnostics
> --pnacl-allow-translate -arch x86-32-nonsfi --pnacl-bias=x86-32-nonsfi
> --target=i686-unknown-nacl -Wall -Wsign-compare -Wendif-labels
> -Wno-missing-field-initializers -Wno-unused-parameter -Werror
> -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
> -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
> -Wno-reserved-user-defined-literal -Wno-sign-compare -O2 -fno-ident
> -fdata-sections -ffunction-sections -g1 -fvisibility=hidden
> -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
> -fno-exceptions -c ../../sandbox/linux/services/syscall_wrappers.cc -o
> newlib_pnacl_nonsfi/obj/sandbox/linux/sandbox_services/syscall_wrappers.o
> ../../sandbox/linux/services/syscall_wrappers.cc:200:1: error: GNU-style
inline
> assembly is disabled
> asm(
> ^
> 1 error generated.
> ninja: build stopped: subcommand failed.
> """

Yes, but this has nothing whatsoever to do with my change.

[Roland McGrath, 2015-11-20 17:47:18]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2015-11-20 17:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460063003/1

[Dirk Pranke, 2015-11-20 17:55:08]

On 2015/11/20 17:47:11, Roland McGrath wrote:
> Yes, but this has nothing whatsoever to do with my change.

Are you sure? Those don't look like flaky failures to me.

Granted, it's not immediately obvious to me how a DEPS roll would cause
this, apart from triggering everything to build, but I don't see any failures
in the other bots that build 'gn_all' after looking briefly.

You probably need to see if you can reproduce this.

[commit-bot: I haz the power, 2015-11-20 18:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 18:11:21]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Roland McGrath, 2015-11-20 18:33:55]

On 2015/11/20 17:55:08, Dirk Pranke wrote:
> On 2015/11/20 17:47:11, Roland McGrath wrote:
> > Yes, but this has nothing whatsoever to do with my change.
> 
> Are you sure? Those don't look like flaky failures to me.
> 
> Granted, it's not immediately obvious to me how a DEPS roll would cause
> this, apart from triggering everything to build, but I don't see any failures
> in the other bots that build 'gn_all' after looking briefly.
> 
> You probably need to see if you can reproduce this.

Yeah, someone on the PNaCl side managed to break the compiler for this nonsfi
case.
Oy.

[Petr Hosek, 2015-11-20 18:41:21]

On 2015/11/20 18:33:55, Roland McGrath wrote:
> On 2015/11/20 17:55:08, Dirk Pranke wrote:
> > On 2015/11/20 17:47:11, Roland McGrath wrote:
> > > Yes, but this has nothing whatsoever to do with my change.
> > 
> > Are you sure? Those don't look like flaky failures to me.
> > 
> > Granted, it's not immediately obvious to me how a DEPS roll would cause
> > this, apart from triggering everything to build, but I don't see any
failures
> > in the other bots that build 'gn_all' after looking briefly.
> > 
> > You probably need to see if you can reproduce this.
> 
> Yeah, someone on the PNaCl side managed to break the compiler for this nonsfi
> case.
> Oy.

That was most likely me, let me look into this.

[Roland McGrath, 2015-11-20 21:59:11]

The CQ bit was checked by mcgrathr@chromium.org

[Roland McGrath, 2015-11-20 21:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dschuff@chromium.org
Link to the patchset: https://codereview.chromium.org/1460063003/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2015-11-20 22:02:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460063003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460063003/20001

[commit-bot: I haz the power, 2015-11-21 00:15:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-21 00:16:34]

Patchset 2 (id:??) landed as
https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
Cr-Commit-Position: refs/heads/master@{#360958}

[magjed_chromium, 2015-11-23 12:36:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1472713003/ by magjed@chromium.org.

The reason for reverting is: I'm speculatively reverting this CL as the cause
for the failing Mac10.6 Tests nacl_integration test. The whole test fails with
this output:
scons: done reading SConscript files.
scons: Building targets ...
Install file: "src/untrusted/pthread/pthread.h" as
"scons-out/nacl-x86-64/include/pthread.h"
Install file: "src/untrusted/pthread/semaphore.h" as
"scons-out/nacl-x86-64/include/semaphore.h"
Install file: "src/untrusted/stubs/crt1.x" as
"scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o"
Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"],
[])
Install file: "src/untrusted/nacl/nacl_random.h" as
"scons-out/nacl-x86-64/include/nacl/nacl_random.h"
Install file: "src/untrusted/nacl/nacl_dyncode.h" as
"scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h"
WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"],
[])
Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"],
[])
Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as
"scons-out/nacl-x86-64/lib/crt1.o"
/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
-m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall
-Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros
-Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1
-D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506
-D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64
-Iscons-out/nacl-x86-64/include
-I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include
-I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src
-I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o
scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o
src/untrusted/nacl/sigprocmask.c
dyld: Library not loaded: /usr/lib/libedit.3.dylib
  Referenced from:
/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
  Reason: image not found

I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac"
https://codereview.chromium.org/1458713003
that e.g. includes this change:
# Required SDK version and target version for Mac builds.
# See MAC_SDK_FLAGS, below.
MAC_SDK_MIN = '10.10'
MAC_DEPLOYMENT_TARGET = '10.6'.