Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1458713003: Fix PNaCl toolchain build on Mac (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Fix PNaCl toolchain build on Mac In the new Mac bot setup, Chromium Clang does not find the Mac SDK automagically and needs an -isysroot switch. This is consistent with how Chromium and NaCl builds work on Mac now. The binutils_x86 build was implicitly using the system compiler and expecting that to work. It no longer works on the new Mac bot setup. This is changed to build with Chromium Clang like all the other components (on Linux too, for consistency). In the old 2.24 binutils base, gold is not compatible with a modern C++ runtime. Rather than hack up fixes or upset the apple-cart with a 2.25 rebase, just disable building gold for now. It's never been officially supported for the direct-to-native NaCl toolchains anyway. BUG= none TEST= toolchain trybots R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/4dbae347415d2448b5418db3439d832b8266893a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -56 lines) Patch
M toolchain_build/toolchain_build_pnacl.py View 16 chunks +107 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
5 years, 1 month ago (2015-11-18 22:32:45 UTC) #1
Derek Schuff
lgtm
5 years, 1 month ago (2015-11-18 23:26:00 UTC) #2
Roland McGrath
5 years, 1 month ago (2015-11-19 00:12:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4dbae347415d2448b5418db3439d832b8266893a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698