Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/BUILD.gn

Issue 1460013003: Re-land "Flip 'Linux x64' bot on chromium waterfall to GN." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update perf_expectations again Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | mojo/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 0a09f8e618d8f4f8b97c3f2bc0eb8045bccf4e16..305d2df39e8914895aed3fd58f909cb605f56bd9 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1026,40 +1026,42 @@ if (is_linux) {
]
}
- action("linux_symbols") {
- script = "//build/linux/dump_app_syms.py"
+ if (is_official_build) {
+ action("linux_symbols") {
+ script = "//build/linux/dump_app_syms.py"
- dump_syms_label = "//breakpad:dump_syms($host_toolchain)"
- dump_syms_binary =
- get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
+ dump_syms_label = "//breakpad:dump_syms($host_toolchain)"
+ dump_syms_binary =
+ get_label_info(dump_syms_label, "root_out_dir") + "/" + "dump_syms"
- chrome_binary = "$root_out_dir/chrome"
- if (current_cpu == "x86") {
- # Use "ia32" instead of "x86" for GYP compat.
- symbol_file = "$root_out_dir/chrome.breakpad.ia32"
- } else {
- symbol_file = "$root_out_dir/chrome.breakpad.$current_cpu"
- }
+ chrome_binary = "$root_out_dir/chrome"
+ if (current_cpu == "x86") {
+ # Use "ia32" instead of "x86" for GYP compat.
+ symbol_file = "$root_out_dir/chrome.breakpad.ia32"
+ } else {
+ symbol_file = "$root_out_dir/chrome.breakpad.$current_cpu"
+ }
- inputs = [
- chrome_binary,
- dump_syms_binary,
- ]
- outputs = [
- symbol_file,
- ]
+ inputs = [
+ chrome_binary,
+ dump_syms_binary,
+ ]
+ outputs = [
+ symbol_file,
+ ]
- args = [
- "./" + rebase_path(dump_syms_binary, root_build_dir),
- "0", # TODO(GYP) This is linux_strip_binary if it is needed.
- rebase_path(chrome_binary, root_build_dir),
- rebase_path(symbol_file, root_build_dir),
- ]
+ args = [
+ "./" + rebase_path(dump_syms_binary, root_build_dir),
+ "0", # TODO(GYP) This is linux_strip_binary if it is needed.
+ rebase_path(chrome_binary, root_build_dir),
+ rebase_path(symbol_file, root_build_dir),
+ ]
- deps = [
- ":chrome",
- dump_syms_label,
- ]
+ deps = [
+ ":chrome",
+ dump_syms_label,
+ ]
+ }
}
# Copies some scripts and resources that are used for desktop integration.
« no previous file with comments | « BUILD.gn ('k') | mojo/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698