Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: BUILD.gn

Issue 1460013003: Re-land "Flip 'Linux x64' bot on chromium waterfall to GN." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update perf_expectations again Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 3522948f486d373a401c52f1df9a67bd69fb1d0a..2d4e60f4d84fa9660fab9c73a5070399dc235b30 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -829,7 +829,12 @@ group("chromium_builder_perf") {
deps += [ "//chrome/test:performance_browser_tests" ]
}
if (is_linux && !is_chromeos) {
- deps += [ "//chrome:linux_symbols" ]
+ if (is_official_build) {
+ # In GN builds, this is controlled by the 'linux_dump_symbols'
+ # flag, which defaults to 1 for official builds. For now,
+ # we skip the separate flag and just key off of is_official_build.
+ deps += [ "//chrome:linux_symbols" ]
+ }
if (!is_chromeos) {
deps += [ "//tools/perf/clear_system_cache" ]
« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698