net/test/url_request/url_request_failed_job.h - Issue 1459993003: [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/url_request/url_request_failed_job.h

Issue 1459993003: [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Steven's comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('K') | « components/cronet/android/test/src/org/chromium/net/MockUrlRequestJobFactory.java ('k') | net/test/url_request/url_request_failed_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/url_request/url_request_failed_job.h

diff --git a/net/test/url_request/url_request_failed_job.h b/net/test/url_request/url_request_failed_job.h

index 45b1911edc86b167c2d09268929e5bfc0fc780f5..578a5c4df7032fdd53ff3acaa1a2894dca226e92 100644

--- a/net/test/url_request/url_request_failed_job.h

+++ b/net/test/url_request/url_request_failed_job.h

@@ -24,7 +24,8 @@ class URLRequestFailedJob : public URLRequestJob {

START = 0,

READ_SYNC = 1,

READ_ASYNC = 2,

- MAX_FAILURE_PHASE = 3,

+ CERT_REQUESTED = 3,

+ MAX_FAILURE_PHASE = 4,

};

URLRequestFailedJob(URLRequest* request,

@@ -42,6 +43,8 @@ class URLRequestFailedJob : public URLRequestJob {

int ReadRawData(IOBuffer* buf, int buf_size) override;

int GetResponseCode() const override;

void GetResponseInfo(HttpResponseInfo* info) override;

+ void ContinueWithCertificate(X509Certificate* client_cert,

+ SSLPrivateKey* client_private_key) override;

// Adds the testing URLs to the URLRequestFilter.

static void AddUrlHandler();