Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 1459993003: [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Steven's comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index 67afcab685dbd172baea4ad9c753cb12cd5bc1c0..5f1e6abe9af7ff44fa32570ad57406d986d8c613 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -554,6 +554,25 @@ public class CronetUrlRequestTest extends CronetTestBase {
}
/**
+ * Tests that request continues when client certificate is requested and the
+ * |arbitraryNetError| is reported later.
+ */
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testMockCertRequested() throws Exception {
+ final int arbitraryNetError = -3;
xunjieli 2015/11/20 18:59:59 It is a bit counterintuitive that we are reporting
mef 2015/11/20 20:51:49 Good point. Done.
+ TestUrlRequestCallback callback =
+ startAndWaitForComplete(MockUrlRequestJobFactory.getMockUrlWithFailure(
+ FailurePhase.CERT_REQUESTED, arbitraryNetError));
+ assertNull(callback.mResponseInfo);
+ assertNotNull(callback.mError);
+ assertEquals(arbitraryNetError, callback.mError.netError());
+ assertEquals(0, callback.mRedirectCount);
+ assertTrue(callback.mOnErrorCalled);
+ assertEquals(callback.mResponseStep, ResponseStep.NOTHING);
+ }
+
+ /**
* Tests that an SSL cert error will be reported via {@link UrlRequest#onFailed}.
*/
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698