components/cronet/android/cronet_url_request_adapter.cc - Issue 1459993003: [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 1459993003: [Cronet] Continue UrlRequest with NULL certificate if Client cert is requested. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Steven's comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.h ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc

index 9f9c524be1f626f386d5e1a43a51850698fc72eb..4d744c05250714a58daa316a6fe297f014b8b263 100644

--- a/components/cronet/android/cronet_url_request_adapter.cc

+++ b/components/cronet/android/cronet_url_request_adapter.cc

@@ -257,6 +257,14 @@ void CronetURLRequestAdapter::OnReceivedRedirect(

*defer_redirect = true;

}

+void CronetURLRequestAdapter::OnCertificateRequested(

+ net::URLRequest* request,

+ net::SSLCertRequestInfo* cert_request_info) {

+ DCHECK(context_->IsOnNetworkThread());

+ // Cronet does not support client certificates.

+ request->ContinueWithCertificate(NULL, NULL);

davidben 2015/11/20 19:02:35 (Drive-by nit: nullptr instead of NULL for new cod

mef 2015/11/20 20:51:49 Done.

void CronetURLRequestAdapter::OnSSLCertificateError(

net::URLRequest* request,

const net::SSLInfo& ssl_info,