third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1459953002: Fix the reference box computation for CSS filter effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1459953002: Fix the reference box computation for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO per review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/filters/filter-region-transformed-child-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 80c7de4745b6e5ccc483acaf4bcc33de4f2a9ce3..1f946b5a9a636e8ab66cff6cb8d1fab02e58c5b7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -1949,8 +1949,8 @@ void LayoutBox::inflatePaintInvalidationRectForReflectionAndFilter(LayoutRect& p

if (hasReflection())

paintInvalidationRect.unite(reflectedRect(paintInvalidationRect));

- if (style()->hasFilter())

- paintInvalidationRect.expand(style()->filterOutsets());

+ if (layer() && layer()->hasFilter())

+ paintInvalidationRect.expand(layer()->filterOutsets());

}

void LayoutBox::invalidatePaintForOverhangingFloats(bool)