Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1459953002: Fix the reference box computation for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO per review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1931 matching lines...) Expand 10 before | Expand all | Expand 10 after
1942 toLayoutView(o)->mapRectToPaintInvalidationBacking(paintInvalidationCont ainer, rect, LayoutView::viewportConstrainedPosition(position), paintInvalidatio nState); 1942 toLayoutView(o)->mapRectToPaintInvalidationBacking(paintInvalidationCont ainer, rect, LayoutView::viewportConstrainedPosition(position), paintInvalidatio nState);
1943 else 1943 else
1944 o->mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, p aintInvalidationState); 1944 o->mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, p aintInvalidationState);
1945 } 1945 }
1946 1946
1947 void LayoutBox::inflatePaintInvalidationRectForReflectionAndFilter(LayoutRect& p aintInvalidationRect) const 1947 void LayoutBox::inflatePaintInvalidationRectForReflectionAndFilter(LayoutRect& p aintInvalidationRect) const
1948 { 1948 {
1949 if (hasReflection()) 1949 if (hasReflection())
1950 paintInvalidationRect.unite(reflectedRect(paintInvalidationRect)); 1950 paintInvalidationRect.unite(reflectedRect(paintInvalidationRect));
1951 1951
1952 if (style()->hasFilter()) 1952 if (layer() && layer()->hasFilter())
1953 paintInvalidationRect.expand(style()->filterOutsets()); 1953 paintInvalidationRect.expand(layer()->filterOutsets());
1954 } 1954 }
1955 1955
1956 void LayoutBox::invalidatePaintForOverhangingFloats(bool) 1956 void LayoutBox::invalidatePaintForOverhangingFloats(bool)
1957 { 1957 {
1958 } 1958 }
1959 1959
1960 void LayoutBox::updateLogicalWidth() 1960 void LayoutBox::updateLogicalWidth()
1961 { 1961 {
1962 LogicalExtentComputedValues computedValues; 1962 LogicalExtentComputedValues computedValues;
1963 computeLogicalWidth(computedValues); 1963 computeLogicalWidth(computedValues);
(...skipping 2868 matching lines...) Expand 10 before | Expand all | Expand 10 after
4832 StyleImage* borderImage = style()->borderImage().image(); 4832 StyleImage* borderImage = style()->borderImage().image();
4833 return borderImage && borderImage->canRender(*this, style()->effectiveZoom() ) && borderImage->isLoaded(); 4833 return borderImage && borderImage->canRender(*this, style()->effectiveZoom() ) && borderImage->isLoaded();
4834 } 4834 }
4835 4835
4836 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const 4836 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const
4837 { 4837 {
4838 return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr; 4838 return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr;
4839 } 4839 }
4840 4840
4841 } // namespace blink 4841 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698