third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h - Issue 1459943002: Clip abspos descendants correctly in all columns (not just the first).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1459943002: Clip abspos descendants correctly in all columns (not just the first). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review - possible alternative Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

index bacdc4e7363564750291bc16ddb78bbf0890ccce..445c11de3356cfaa46b31d290a4b01710cfe2b58 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

@@ -170,6 +170,8 @@ public:

bool isPageLogicalHeightKnown() const final;

+ LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool* offsetDependsOnPoint = nullptr) const final;

LayoutSize flowThreadTranslationAtOffset(LayoutUnit) const;

LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const override;