Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1459943002: Clip abspos descendants correctly in all columns (not just the first). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review - possible alternative Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 LayoutUnit tallestUnbreakableLogicalHeight(LayoutUnit offsetInFlowThread) co nst; 164 LayoutUnit tallestUnbreakableLogicalHeight(LayoutUnit offsetInFlowThread) co nst;
165 165
166 LayoutSize columnOffset(const LayoutPoint&) const final; 166 LayoutSize columnOffset(const LayoutPoint&) const final;
167 167
168 // Do we need to set a new width and lay out? 168 // Do we need to set a new width and lay out?
169 virtual bool needsNewWidth() const; 169 virtual bool needsNewWidth() const;
170 170
171 bool isPageLogicalHeightKnown() const final; 171 bool isPageLogicalHeightKnown() const final;
172 172
173 LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool * offsetDependsOnPoint = nullptr) const final;
174
173 LayoutSize flowThreadTranslationAtOffset(LayoutUnit) const; 175 LayoutSize flowThreadTranslationAtOffset(LayoutUnit) const;
174 176
175 LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) con st override; 177 LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) con st override;
176 178
177 LayoutMultiColumnSet* columnSetAtBlockOffset(LayoutUnit) const final; 179 LayoutMultiColumnSet* columnSetAtBlockOffset(LayoutUnit) const final;
178 180
179 void layoutColumns(SubtreeLayoutScope&); 181 void layoutColumns(SubtreeLayoutScope&);
180 182
181 // Skip past a column spanner during flow thread layout. Spanners are not la id out inside the 183 // Skip past a column spanner during flow thread layout. Spanners are not la id out inside the
182 // flow thread, since the flow thread is not in a spanner's containing block chain (since the 184 // flow thread, since the flow thread is not in a spanner's containing block chain (since the
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 bool m_isBeingEvacuated; 251 bool m_isBeingEvacuated;
250 }; 252 };
251 253
252 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in 254 // Cannot use DEFINE_LAYOUT_OBJECT_TYPE_CASTS here, because isMultiColumnFlowThr ead() is defined in
253 // LayoutFlowThread, not in LayoutObject. 255 // LayoutFlowThread, not in LayoutObject.
254 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread()); 256 DEFINE_TYPE_CASTS(LayoutMultiColumnFlowThread, LayoutFlowThread, object, object- >isLayoutMultiColumnFlowThread(), object.isLayoutMultiColumnFlowThread());
255 257
256 } // namespace blink 258 } // namespace blink
257 259
258 #endif // LayoutMultiColumnFlowThread_h 260 #endif // LayoutMultiColumnFlowThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698