pkg/pkg_files.gyp - Issue 1459893002: Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/pkg_files.gyp

Issue 1459893002: Exclude any *_test.dart and */test/*dart when creating stamp files for pkg and third_party/pkg (Closed) Base URL: https://github.com/dart-lang/sdk.git@_temporary_fletch_patches

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/pkg_files.gyp

diff --git a/pkg/pkg_files.gyp b/pkg/pkg_files.gyp

index 78a751ff7a87ec76e3cbe0f6be1859263e4e1ed6..fa3b400618d43e09425fab01de7c11f2b28b7e21 100644

--- a/pkg/pkg_files.gyp

+++ b/pkg/pkg_files.gyp

@@ -16,7 +16,9 @@

'action_name': 'make_pkg_files_stamp',

'inputs': [

'../tools/create_timestamp_file.py',

- '<!@(["python", "../tools/list_files.py", "\\.dart$", "."])',

+ '<!@(["python", "../tools/list_files.py",'

+ '"^(?!.*/test/).*(?<!_test)[.]dart$",'

+ '"."])',

'<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files.stamp',

'outputs': [

@@ -32,7 +34,7 @@

'inputs': [

'../tools/create_timestamp_file.py',

'<!@(["python", "../tools/list_files.py",'

- '"^(?!.*_test.dart).*dart$",'

+ '"^(?!.*/test/).*(?<!_test)[.]dart$",'

'"../third_party/pkg"])',

'outputs': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »