Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1459843002: Fix a style guide violation in KeyedService. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a style guide violation in KeyedService. According to the style guide [1], constructors and destructor should come before any other method declaration. Fixes KeyedService method ordering to follow said guide. [1]: https://google.github.io/styleguide/cppguide.html#Declaration_Order BUG=None Committed: https://crrev.com/e34c4d70f455816654cb51dfacf832db7228b610 Cr-Commit-Position: refs/heads/master@{#360797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/keyed_service/core/keyed_service.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
As pointed out in https://codereview.chromium.org/1438043008/diff/360001/components/ntp_snippets/ntp_snippets_service.h#newcode23components/ntp_snippets/ntp_snippets_service.h:23 KeyedService method declaration order was not following the style guide. ...
5 years, 1 month ago (2015-11-19 11:46:20 UTC) #2
Elliot Glaysher
lgtm
5 years, 1 month ago (2015-11-19 18:26:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459843002/1
5 years, 1 month ago (2015-11-19 18:29:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98460)
5 years, 1 month ago (2015-11-19 18:45:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459843002/1
5 years, 1 month ago (2015-11-20 09:58:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 10:57:08 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 10:57:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e34c4d70f455816654cb51dfacf832db7228b610
Cr-Commit-Position: refs/heads/master@{#360797}

Powered by Google App Engine
This is Rietveld 408576698