Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 1438043008: Creating the NTP snippet service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding missing explicit. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
6 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
7
8 #include <string>
9
10 #include "base/macros.h"
11 #include "components/keyed_service/core/keyed_service.h"
12
13 namespace ntp_snippets {
14
15 // Stores and vend fresh content data for the NTP.
16 class NTPSnippetsService : public KeyedService {
17 public:
18 // |application_language_code| should be a ISO 639-1 compliant string. Aka
19 // 'en' or 'en-US'. Note that this code should only specify the language, not
20 // the locale, so 'en_US' (english language with US locale) and 'en-GB_US'
21 // (British english person in the US) are not language code.
22 explicit NTPSnippetsService(const std::string& application_language_code);
23 void Shutdown() override;
sdefresne 2015/11/18 17:59:06 style: the constructor and destructor must come be
noyau (Ping after 24h) 2015/11/19 09:08:21 Again, this is the same order as in the superclass
sdefresne 2015/11/19 11:34:43 This does not seems to be what other classes inher
sdefresne 2015/11/19 11:46:49 Sent https://codereview.chromium.org/1459843002 to
noyau (Ping after 24h) 2015/11/19 12:36:14 Done.
24 ~NTPSnippetsService() override;
25
26 // TODO(crbug.com/547046): Add API.
27 private:
28 // The ISO 639-1 code of the language used by the application.
29 const std::string application_language_code_;
30
31 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsService);
32 };
33
34 } // namespace ntp_snippets
35
36 #endif // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698