Chromium Code Reviews
Help | Chromium Project | Sign in
(28)

Issue 14598015: [Mac][MC] Implement notification updates and relayouts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Robert Sesek
Modified:
2 years, 2 months ago
Reviewers:
sail, dewittj
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

[Mac][MC] Implement notification updates and relayouts. BUG=179904 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198592

Patch Set 1 #

Total comments: 7

Patch Set 2 : Review comments #

Messages

Total messages: 9 (0 generated)
Robert Sesek
2 years, 2 months ago (2013-05-03 20:55:19 UTC) #1
sail
Objective-C code LGTM https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it ...
2 years, 2 months ago (2013-05-03 21:42:32 UTC) #2
Robert Sesek
https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it != modelPopups.end(); ++it) ...
2 years, 2 months ago (2013-05-03 21:59:18 UTC) #3
dewittj
lgtm https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it != modelPopups.end(); ...
2 years, 2 months ago (2013-05-03 22:31:37 UTC) #4
Robert Sesek
On 2013/05/03 22:31:37, dewittj wrote: > lgtm > > https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm > File ui/message_center/cocoa/popup_collection.mm (right): > ...
2 years, 2 months ago (2013-05-06 19:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/14598015/7001
2 years, 2 months ago (2013-05-06 19:32:42 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=125766
2 years, 2 months ago (2013-05-06 23:30:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/14598015/7001
2 years, 2 months ago (2013-05-07 01:17:42 UTC) #8
commit-bot: I haz the power
2 years, 2 months ago (2013-05-07 01:59:00 UTC) #9
Message was sent while issue was closed.
Change committed as 198592
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5