Chromium Code Reviews
Help | Chromium Project | Sign in
(252)

Issue 14598015: [Mac][MC] Implement notification updates and relayouts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 3 weeks ago by rsesek
Modified:
11 months, 2 weeks ago
Reviewers:
sail, dewittj
CC:
chromium-reviews_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

[Mac][MC] Implement notification updates and relayouts.

BUG=179904
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198592

Patch Set 1 #

Total comments: 7

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -68 lines) Lint Patch
M ui/message_center/cocoa/notification_controller.h View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M ui/message_center/cocoa/notification_controller.mm View 4 chunks +48 lines, -28 lines 0 comments ? errors Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 chunk +29 lines, -0 lines 0 comments ? errors Download
M ui/message_center/cocoa/popup_collection.mm View 1 5 chunks +119 lines, -39 lines 0 comments ? errors Download
M ui/message_center/cocoa/popup_collection_unittest.mm View 3 chunks +55 lines, -0 lines 0 comments ? errors Download
M ui/message_center/cocoa/popup_controller.h View 1 chunk +4 lines, -1 line 0 comments 1 errors Download
M ui/message_center/cocoa/popup_controller.mm View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
rsesek
11 months, 3 weeks ago #1
sail
Objective-C code LGTM https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it ...
11 months, 3 weeks ago #2
rsesek
https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it != modelPopups.end(); ++it) ...
11 months, 3 weeks ago #3
dewittj
lgtm https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm File ui/message_center/cocoa/popup_collection.mm (right): https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm#newcode156 ui/message_center/cocoa/popup_collection.mm:156: for (auto it = modelPopups.begin(); it != modelPopups.end(); ...
11 months, 3 weeks ago #4
rsesek
On 2013/05/03 22:31:37, dewittj wrote: > lgtm > > https://codereview.chromium.org/14598015/diff/1/ui/message_center/cocoa/popup_collection.mm > File ui/message_center/cocoa/popup_collection.mm (right): > ...
11 months, 2 weeks ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/14598015/7001
11 months, 2 weeks ago #6
I haz the power (commit-bot)
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=125766
11 months, 2 weeks ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/14598015/7001
11 months, 2 weeks ago #8
I haz the power (commit-bot)
11 months, 2 weeks ago #9
Message was sent while issue was closed.
Change committed as 198592
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6