Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Issue 145973022: A64: Truncate booleans to 0 or 1 in LTaggedToI. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
Reviewers:
m.m.capewell, jbramley
CC:
v8-dev
Visibility:
Public.

Description

A64: Truncate booleans to 0 or 1 in LTaggedToI. R=m.m.capewell@googlemail.com Committed: https://code.google.com/p/v8/source/detail?r=19120

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL
6 years, 10 months ago (2014-02-05 18:21:26 UTC) #1
m.m.capewell
https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc#newcode5132 src/a64/lithium-codegen-a64.cc:5132: __ JumpIfNotRoot(scratch1, Heap::kTrueValueRootIndex, &check_false); It may be better to ...
6 years, 10 months ago (2014-02-05 18:43:23 UTC) #2
ulan
Thanks, I uploaded new patch set. https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/145973022/diff/1/src/a64/lithium-codegen-a64.cc#newcode5132 src/a64/lithium-codegen-a64.cc:5132: __ JumpIfNotRoot(scratch1, Heap::kTrueValueRootIndex, ...
6 years, 10 months ago (2014-02-05 19:21:29 UTC) #3
m.m.capewell
lgtm
6 years, 10 months ago (2014-02-05 19:35:54 UTC) #4
ulan
6 years, 10 months ago (2014-02-05 19:56:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19120 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698