Support cross-profile copy between Chrome OS Google Drive folders.

Support cross-profile copy between Chrome OS Google Drive folders.

Previously the processing of Drive entries are delegated to the
running profile of the apps, but now it is passed to the owning
profiles of each entries.

BUG=339706
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248921

[kinaba, 2014-02-04 02:47:07]

Depends on https://codereview.chromium.org/150163003/.

[kinaba, 2014-02-04 02:48:48]

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc:27:
FileSystemBackendDelegate::FileSystemBackendDelegate(
Probably whole the class can be removed and merged to FileSystemBackend. I'll do
it separately later and concentrate the current patch to switching the profile
source from profile_id_ to url.

[hashimoto, 2014-02-04 05:44:36]

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fileapi/async_file_util.cc (right):

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fileapi/async_file_util.cc:294: // Check that
src_url and dest_url are from the same profile.
What does this comment mean?
New check is introduced by this change?

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc:28:
content::BrowserContext* browser_context)
nit: browser_context and profile_id_ are not needed?

[kinaba, 2014-02-04 06:10:58]

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fileapi/async_file_util.cc (right):

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fileapi/async_file_util.cc:294: // Check that
src_url and dest_url are from the same profile.
On 2014/02/04 05:44:36, hashimoto wrote:
> What does this comment mean?
> New check is introduced by this change?

Oops, I meant TODO comment by this. Updated in detail.

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
(right):

https://codereview.chromium.org/145973016/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc:28:
content::BrowserContext* browser_context)
On 2014/02/04 05:44:36, hashimoto wrote:
> nit: browser_context and profile_id_ are not needed?

Done.

Not needed and since I thought holding profile_id_ is the whole reason
FileSystemBackendDelegate existed, I'm thinking about removing them all at once
along with the removal of the Delegate class. But I changed my mind that the
class is still giving a separation between general filesystem and Drive
filesystem and hence can be kept. For now, I'll just remove the unneeded fields.

[hashimoto, 2014-02-04 06:32:02]

lgtm

[kinaba, 2014-02-05 04:28:06]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-02-05 04:41:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/145973016/90001

[commit-bot: I haz the power, 2014-02-05 08:27:35]

Change committed as 248921