Support cross-profile copy between Chrome OS Google Drive folders.

chrome/browser/chromeos/drive/fileapi/async_file_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/fileapi/async_file_util.h"
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/platform_file.h"
 #include "base/threading/sequenced_worker_pool.h"
+#include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/drive/fileapi/fileapi_worker.h"
 #include "content/public/browser/browser_thread.h"
 #include "google_apis/drive/task_util.h"
 #include "webkit/browser/fileapi/file_system_operation_context.h"
 #include "webkit/browser/fileapi/file_system_url.h"
 #include "webkit/common/blob/shareable_file_reference.h"
 
 using content::BrowserThread;
 
@@ skipping 17 matching lines @@
                  file_system_getter, function,
                  on_error_callback.is_null() ?
                  base::Closure() :
                  base::Bind(&google_apis::RunTaskOnThread,
                             base::MessageLoopProxy::current(),
                             on_error_callback)));
 }
 
 // Runs CreateOrOpenFile callback based on the given |error| and |file|.
 void RunCreateOrOpenFileCallback(
-    const AsyncFileUtil::FileSystemGetter& file_system_getter,
+    const fileapi_internal::FileSystemGetter& file_system_getter,
     const base::FilePath& file_path,
     const AsyncFileUtil::CreateOrOpenCallback& callback,
     base::File::Error error,
     base::PlatformFile file,
     const base::Closure& close_callback_on_ui_thread) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   // It is necessary to make a closure, which runs on file closing here.
   // It will be provided as a FileSystem::OpenFileCallback's argument later.
   // (crbug.com/259184).
@@ skipping 47 matching lines @@
   scoped_refptr<webkit_blob::ShareableFileReference> file_reference =
       webkit_blob::ShareableFileReference::GetOrCreate(webkit_blob::ScopedFile(
           local_path,
           scope_out_policy,
           BrowserThread::GetBlockingPool()));
   callback.Run(error, file_info, local_path, file_reference);
 }
 
 }  // namespace
 
-AsyncFileUtil::AsyncFileUtil(const FileSystemGetter& file_system_getter)
-    : file_system_getter_(file_system_getter) {
+AsyncFileUtil::AsyncFileUtil() {
 }
 
 AsyncFileUtil::~AsyncFileUtil() {
 }
 
 void AsyncFileUtil::CreateOrOpen(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     int file_flags,
     const CreateOrOpenCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     base::PlatformFile platform_file = base::kInvalidPlatformFileValue;
     callback.Run(base::File::FILE_ERROR_NOT_FOUND,
                  base::PassPlatformFile(&platform_file),
                  base::Closure());
     return;
   }
 
+  const fileapi_internal::FileSystemGetter getter =
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url);
   PostFileSystemCallback(
-      file_system_getter_,
+      getter,
       base::Bind(&fileapi_internal::OpenFile,
                  file_path, file_flags,
                  google_apis::CreateRelayCallback(
                      base::Bind(&RunCreateOrOpenFileCallback,
-                                file_system_getter_, file_path, callback))),
+                                getter, file_path, callback))),
       base::Bind(&RunCreateOrOpenFileCallbackOnError,
                  callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::EnsureFileExists(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const EnsureFileExistsCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND, false);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::CreateFile,
                  file_path, true /* is_exlusive */,
                  google_apis::CreateRelayCallback(
                      base::Bind(&RunEnsureFileExistsCallback, callback))),
       base::Bind(callback, base::File::FILE_ERROR_FAILED, false));
 }
 
 void AsyncFileUtil::CreateDirectory(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     bool exclusive,
     bool recursive,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::CreateDirectory,
                  file_path, exclusive, recursive,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::GetFileInfo(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const GetFileInfoCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND, base::File::Info());
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::GetFileInfo,
                  file_path, google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED,
                  base::File::Info()));
 }
 
 void AsyncFileUtil::ReadDirectory(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const ReadDirectoryCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND, EntryList(), false);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::ReadDirectory,
                  file_path, google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED,
                  EntryList(), false));
 }
 
 void AsyncFileUtil::Touch(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const base::Time& last_access_time,
     const base::Time& last_modified_time,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::TouchFile,
                  file_path, last_access_time, last_modified_time,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::Truncate(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     int64 length,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::Truncate,
                  file_path, length, google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::CopyFileLocal(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& src_url,
     const fileapi::FileSystemURL& dest_url,
     CopyOrMoveOption option,
     const CopyFileProgressCallback& progress_callback,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath src_path = util::ExtractDrivePathFromFileSystemUrl(src_url);
   base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
   if (src_path.empty() || dest_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
+  // Check that src_url and dest_url are from the same profile.

[hashimoto, 2014/02/04 05:44:36]

What does this comment mean?
New check is introduced by this change?

[kinaba, 2014/02/04 06:10:59]

Oops, I meant TODO comment by this. Updated in detail.

   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, dest_url),
       base::Bind(
           &fileapi_internal::Copy,
           src_path, dest_path,
           option == fileapi::FileSystemOperation::OPTION_PRESERVE_LAST_MODIFIED,
           google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::MoveFileLocal(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& src_url,
     const fileapi::FileSystemURL& dest_url,
     CopyOrMoveOption option,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath src_path = util::ExtractDrivePathFromFileSystemUrl(src_url);
   base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
   if (src_path.empty() || dest_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
+  // Check that src_url and dest_url are from the same profile.
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, dest_url),
       base::Bind(
           &fileapi_internal::Move,
           src_path, dest_path,
           option == fileapi::FileSystemOperation::OPTION_PRESERVE_LAST_MODIFIED,
           google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::CopyInForeignFile(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const base::FilePath& src_file_path,
     const fileapi::FileSystemURL& dest_url,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
   if (dest_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, dest_url),
       base::Bind(&fileapi_internal::CopyInForeignFile,
                  src_file_path, dest_path,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::DeleteFile(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::Remove,
                  file_path, false /* not recursive */,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::DeleteDirectory(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::Remove,
                  file_path, false /* not recursive */,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::DeleteRecursively(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const StatusCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::Remove,
                  file_path, true /* recursive */,
                  google_apis::CreateRelayCallback(callback)),
       base::Bind(callback, base::File::FILE_ERROR_FAILED));
 }
 
 void AsyncFileUtil::CreateSnapshotFile(
     scoped_ptr<fileapi::FileSystemOperationContext> context,
     const fileapi::FileSystemURL& url,
     const CreateSnapshotFileCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
   if (file_path.empty()) {
     callback.Run(base::File::FILE_ERROR_NOT_FOUND,
                  base::File::Info(),
                  base::FilePath(),
                  scoped_refptr<webkit_blob::ShareableFileReference>());
     return;
   }
 
   PostFileSystemCallback(
-      file_system_getter_,
+      base::Bind(&fileapi_internal::GetFileSystemFromUrl, url),
       base::Bind(&fileapi_internal::CreateSnapshotFile,
                  file_path,
                  google_apis::CreateRelayCallback(
                      base::Bind(&RunCreateSnapshotFileCallback, callback))),
       base::Bind(callback,
                  base::File::FILE_ERROR_FAILED,
                  base::File::Info(),
                  base::FilePath(),
                  scoped_refptr<webkit_blob::ShareableFileReference>()));
 }
 
 }  // namespace internal
 }  // namespace drive