Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 145973015: MIPS: Unroll push loop in r19040 and other push optimizations. (Closed)

Created:
6 years, 10 months ago by palfia
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Unroll push loop in r19040 and other push optimizations. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=19042

Patch Set 1 #

Patch Set 2 : Update comment. #

Patch Set 3 : Fix for loop and other microoptimizations. #

Patch Set 4 : Revert an optimization. #

Patch Set 5 : Fix Pop order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
src/mips/builtins-mips.cc View 1 2 3 chunks +4 lines, -8 lines 0 comments Download
src/mips/code-stubs-mips.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
src/mips/full-codegen-mips.cc View 1 2 3 4 chunks +6 lines, -11 lines 0 comments Download
src/mips/lithium-codegen-mips.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
src/mips/stub-cache-mips.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
6 years, 10 months ago (2014-02-04 00:00:02 UTC) #1
Paul Lind
LGTM, thanks.
6 years, 10 months ago (2014-02-04 00:03:55 UTC) #2
palfia
6 years, 10 months ago (2014-02-04 00:06:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r19042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698