src/mips/lithium-codegen-mips.cc - Issue 145973015: MIPS: Unroll push loop in r19040 and other push optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 145973015: MIPS: Unroll push loop in r19040 and other push optimizations. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix Pop order. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index eef54058e0314164b478d94c3bee7ca11eed62cf..a2df23fc5a88bcd6278f2a46a3b70fc3944bb6bd 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -179,8 +179,7 @@ bool LCodeGen::GeneratePrologue() {

if (slots > 0) {

if (FLAG_debug_code) {

__ Subu(sp, sp, Operand(slots * kPointerSize));

- __ push(a0);

- __ push(a1);

+ __ Push(a0, a1);

__ Addu(a0, sp, Operand(slots * kPointerSize));

__ li(a1, Operand(kSlotsZapValue));

Label loop;

@@ -188,8 +187,7 @@ bool LCodeGen::GeneratePrologue() {

__ Subu(a0, a0, Operand(kPointerSize));

__ sw(a1, MemOperand(a0, 2 * kPointerSize));

__ Branch(&loop, ne, a0, Operand(sp));

- __ pop(a1);

- __ pop(a0);

+ __ Pop(a0, a1);

} else {

__ Subu(sp, sp, Operand(slots * kPointerSize));

}

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »