Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 145973011: clean up a couple of parameters in the tracing interface (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

clean up a couple of parameters in the tracing interface BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13283

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/utils/SkEventTracer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
humper
PTAL -- just cleaning up two small whoopsies in the parameter types/names that I noticed ...
6 years, 10 months ago (2014-02-03 17:31:40 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/145973011/diff/1/src/utils/SkEventTracer.cpp File src/utils/SkEventTracer.cpp (right): https://codereview.chromium.org/145973011/diff/1/src/utils/SkEventTracer.cpp#newcode26 src/utils/SkEventTracer.cpp:26: SkEventTracer::Handle handle) SK_OVERRIDE {}; just fyi, skia style ...
6 years, 10 months ago (2014-02-03 17:46:25 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-02-03 17:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/145973011/1
6 years, 10 months ago (2014-02-03 17:52:27 UTC) #4
commit-bot: I haz the power
Change committed as 13283
6 years, 10 months ago (2014-02-03 18:09:49 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 18:10:13 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 18:11:14 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698