Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: src/utils/SkEventTracer.cpp

Issue 145973011: clean up a couple of parameters in the tracing interface (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/utils/SkEventTracer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkEventTracer.h" 8 #include "SkEventTracer.h"
9 #include "SkOnce.h" 9 #include "SkOnce.h"
10 10
11 class SkDefaultEventTracer: public SkEventTracer { 11 class SkDefaultEventTracer: public SkEventTracer {
12 virtual SkEventTracer::Handle 12 virtual SkEventTracer::Handle
13 addTraceEvent(char phase, 13 addTraceEvent(char phase,
14 const uint8_t* categoryEnabledFlag, 14 const uint8_t* categoryEnabledFlag,
15 const char* name, 15 const char* name,
16 uint64_t id, 16 uint64_t id,
17 int numArgs, 17 int numArgs,
18 const char** argNames, 18 const char** argNames,
19 const uint8_t* argTypes, 19 const uint8_t* argTypes,
20 const uint64_t* argValues, 20 const uint64_t* argValues,
21 uint8_t flags) SK_OVERRIDE { return 0; } 21 uint8_t flags) SK_OVERRIDE { return 0; }
22 22
23 virtual void 23 virtual void
24 updateTraceEventDuration(const uint8_t* categoryEnabledFlag, 24 updateTraceEventDuration(const uint8_t* categoryEnabledFlag,
25 const char* name, 25 const char* name,
26 SkEventTracer::Handle) SK_OVERRIDE {}; 26 SkEventTracer::Handle handle) SK_OVERRIDE {};
bsalomon 2014/02/03 17:46:26 just fyi, skia style allows unnamed params in the
27 27
28 virtual const uint8_t* getCategoryGroupEnabled(const char* name) SK_OVERRIDE { 28 virtual const uint8_t* getCategoryGroupEnabled(const char* name) SK_OVERRIDE {
29 static uint8_t no = 0; 29 static uint8_t no = 0;
30 return &no; 30 return &no;
31 }; 31 };
32 virtual const char* getCategoryGroupName( 32 virtual const char* getCategoryGroupName(
33 const uint8_t* category_group_enabled) SK_OVERRIDE { 33 const uint8_t* category_group_enabled) SK_OVERRIDE {
34 static const char* dummy = "dummy"; 34 static const char* dummy = "dummy";
35 return dummy; 35 return dummy;
36 }; 36 };
37 }; 37 };
38 38
39 SkEventTracer *SkEventTracer::gInstance; 39 SkEventTracer *SkEventTracer::gInstance;
40 40
41 static void intiailize_default_tracer(int) { 41 static void intiailize_default_tracer(int) {
42 SkEventTracer::SetInstance(SkNEW(SkDefaultEventTracer)); 42 SkEventTracer::SetInstance(SkNEW(SkDefaultEventTracer));
43 } 43 }
44 44
45 static void cleanup_tracer() { 45 static void cleanup_tracer() {
46 // calling SetInstance will delete the existing instance. 46 // calling SetInstance will delete the existing instance.
47 SkEventTracer::SetInstance(NULL); 47 SkEventTracer::SetInstance(NULL);
48 } 48 }
49 49
50 SkEventTracer* SkEventTracer::GetInstance() { 50 SkEventTracer* SkEventTracer::GetInstance() {
51 SK_DECLARE_STATIC_ONCE(once); 51 SK_DECLARE_STATIC_ONCE(once);
52 SkOnce(&once, intiailize_default_tracer, 0, cleanup_tracer); 52 SkOnce(&once, intiailize_default_tracer, 0, cleanup_tracer);
53 SkASSERT(NULL != SkEventTracer::gInstance); 53 SkASSERT(NULL != SkEventTracer::gInstance);
54 return SkEventTracer::gInstance; 54 return SkEventTracer::gInstance;
55 } 55 }
OLDNEW
« no previous file with comments | « include/utils/SkEventTracer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698