Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1459723002: MIPS: [turbofan] Add matching rule to use Nor instruction. (Closed)

Created:
5 years, 1 month ago by dusan.milosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Add matching rule to use Nor instruction. TEST=unittests/InstructionSelectorTest.Word32XorMinusOneWithWord32Or, Word64XorMinusOneWithWord64Or BUG= Committed: https://crrev.com/40a501a26a7ab3fc68ec7f10953a4dd546595ea0 Cr-Commit-Position: refs/heads/master@{#32149}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed mips32. #

Patch Set 3 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dusan.milosavljevic
PTAL.
5 years, 1 month ago (2015-11-18 21:58:49 UTC) #2
paul.l...
Ákos, Balázs, could you guys take a look at this one?
5 years, 1 month ago (2015-11-19 06:07:45 UTC) #4
balazs.kilvady
32 bits part must be fixed. Tests passed on mips64el. https://codereview.chromium.org/1459723002/diff/1/src/compiler/mips/instruction-selector-mips.cc File src/compiler/mips/instruction-selector-mips.cc (right): https://codereview.chromium.org/1459723002/diff/1/src/compiler/mips/instruction-selector-mips.cc#newcode302 ...
5 years, 1 month ago (2015-11-19 12:28:32 UTC) #5
dusan.milosavljevic
https://codereview.chromium.org/1459723002/diff/1/src/compiler/mips/instruction-selector-mips.cc File src/compiler/mips/instruction-selector-mips.cc (right): https://codereview.chromium.org/1459723002/diff/1/src/compiler/mips/instruction-selector-mips.cc#newcode302 src/compiler/mips/instruction-selector-mips.cc:302: MipsperandGenerator g(this); On 2015/11/19 12:28:31, balazs.kilvady wrote: > error: ...
5 years, 1 month ago (2015-11-19 12:50:05 UTC) #6
dusan.milosavljevic
PTAL.
5 years, 1 month ago (2015-11-20 12:26:36 UTC) #7
balazs.kilvady
lgtm
5 years, 1 month ago (2015-11-20 13:21:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459723002/40001
5 years, 1 month ago (2015-11-20 13:41:49 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-20 14:00:23 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 14:00:36 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40a501a26a7ab3fc68ec7f10953a4dd546595ea0
Cr-Commit-Position: refs/heads/master@{#32149}

Powered by Google App Engine
This is Rietveld 408576698