Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459683003: `analyzer_cli` move to SDK. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

`analyzer_cli` move to SDK. Tracking bug: https://github.com/dart-lang/sdk/issues/24731 Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/ Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994 BUG=24731 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/9ae1265ff534c9a189d7ac4cbcbc7b6ca282debc

Patch Set 1 #

Patch Set 2 : acli sources #

Patch Set 3 : docs #

Patch Set 4 : master merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3372 lines, -53 lines) Patch
M DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
A pkg/analyzer_cli/.gitignore View 1 1 chunk +11 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/CHANGELOG.md View 1 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/README.md View 1 1 chunk +87 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/bin/analyzer.dart View 1 1 chunk +7 lines, -12 lines 0 comments Download
A pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 1 chunk +303 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/bootloader.dart View 1 1 chunk +196 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/driver.dart View 1 1 chunk +641 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/error_formatter.dart View 1 1 chunk +196 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/options.dart View 1 1 chunk +485 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/plugin/plugin_manager.dart View 1 1 chunk +110 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/pubspec.yaml View 1 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/all.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/angular_options.yaml View 1 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/bad_plugin_options.yaml View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/empty_options.yaml View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/analyzer_cli/test/data/file_with_error.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/file_with_hint.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/file_with_warning.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/library_and_parts/lib.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/library_and_parts/part1.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/library_and_parts/part2.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/linter_project/.analysis_options View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/linter_project/test_file.dart View 1 1 chunk +2 lines, -6 lines 0 comments Download
A pkg/analyzer_cli/test/data/no_lints_project/.analysis_options View 1 1 chunk +1 line, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/no_lints_project/test_file.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer_cli/test/data/no_packages_file/sdk_ext_user.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/analyzer_cli/test/data/options_tests_project/.analysis_options View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/options_tests_project/test_file.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
A pkg/analyzer_cli/test/data/package_with_sdk_extension/lib/_sdkext View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/package_with_sdk_extension/lib/foo.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer_cli/test/data/packages_file/sdk_ext_user.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/analyzer_cli/test/data/plugin_options.yaml View 1 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/strong_example.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
A + pkg/analyzer_cli/test/data/super_mixin_example.dart View 1 1 chunk +10 lines, -11 lines 0 comments Download
A + pkg/analyzer_cli/test/data/test_file.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
A pkg/analyzer_cli/test/data/test_options.yaml View 1 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/driver_test.dart View 1 1 chunk +484 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/error_test.dart View 1 1 chunk +55 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/mocks.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/options_test.dart View 1 1 chunk +191 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/plugin_manager_test.dart View 1 1 chunk +94 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/reporter_test.dart View 1 1 chunk +77 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/sdk_ext_test.dart View 1 1 chunk +55 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/strong_mode_test.dart View 1 1 chunk +53 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/super_mixin_test.dart View 1 1 chunk +67 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/utils.dart View 1 1 chunk +56 lines, -0 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 chunk +1 line, -1 line 0 comments Download
M tools/make_links.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
5 years, 1 month ago (2015-11-19 19:17:41 UTC) #2
Bill Hesse
LGTM. It's always amazing how simple these changes turn out to be. I thought we ...
5 years, 1 month ago (2015-11-19 22:32:28 UTC) #4
pquitslund
On 2015/11/19 22:32:28, Bill Hesse wrote: > LGTM. It's always amazing how simple these changes ...
5 years, 1 month ago (2015-11-19 22:40:50 UTC) #5
pquitslund
5 years, 1 month ago (2015-11-19 22:53:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
9ae1265ff534c9a189d7ac4cbcbc7b6ca282debc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698