Issue 1453413006: analyzer_cli move dartium build updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1453413006: analyzer_cli move dartium build updates. (Closed)

Created:
5 years, 1 month ago by pquitslund

Modified:
5 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

analyzer_cli move dartium build updates. Tracking bug: https://github.com/dart-lang/sdk/issues/24731 BUG=24731

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -7 lines)			Patch
M	DEPS	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sdk/bin/dartanalyzer	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/bin/dartanalyzer.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/dartanalyzer/dartanalyzer.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

I don't understand this CL. It seems to be the same changes that are in ...

5 years, 1 month ago (2015-11-19 22:37:26 UTC) #3

pquitslund

5 years, 1 month ago (2015-11-19 22:48:41 UTC) #4

On 2015/11/19 22:37:26, Bill Hesse wrote:
> I don't understand this CL.  It seems to be the same changes that are in the
> main one, adding analyzer_cli to /pkg.  It isn't changing anything for dartium
> that I see.  What am I missing?

Nothing.  This was a mistake on my part.  At some point I needed to update
dartium DEPS (I think when I added something to third_party) and I got
over-zealous.  Somehow my local dartium repo is pointing actually at the sdk so
this is doubly confusing.  Anyway, thanks!  I'll close this out...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages