Issue 1459673003: Add recognizing register-shifted forms in ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459673003: Add recognizing register-shifted forms in ARM assembler. (Closed)

Created:
5 years, 1 month ago by Karl

Modified:
5 years, 1 month ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add recognizing register-shifted forms in ARM assembler. Extends the ARM integrated assembler to understand register-shifted data processing instructions (add, sub, etc.), as well as cmp/test instructions. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4b170e46e496bcc2384af24ba2331e84a1ccadff

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -0 lines)			Patch
	M	src/IceAssemblerARM32.cpp	View	1 2	5 chunks	+23 lines, -0 lines	0 comments	Download
	A	tests_lit/assembler/arm32/cmp.ll	View	1 2	1 chunk	+196 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Karl

5 years, 1 month ago (2015-11-20 22:42:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
4b170e46e496bcc2384af24ba2331e84a1ccadff (presubmit successful).