Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1459663002: simplify insertion methods for SkTLList (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify insertion methods for SkTLList Committed: https://skia.googlesource.com/skia/+/5aaef1ff1a18b420b3409ec31b44c2435a4ac988

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : include <utility> #

Patch Set 4 : fix gcc? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -102 lines) Patch
M src/core/SkTLList.h View 1 2 3 5 chunks +18 lines, -93 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/LListTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
bsalomon
makes modifying this to have a prealloc block simpler, and is just a nice cleanup ...
5 years, 1 month ago (2015-11-18 19:43:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459663002/20001
5 years, 1 month ago (2015-11-18 19:43:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-18 19:43:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4237) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 19:44:25 UTC) #7
joshualitt
On 2015/11/18 19:43:34, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 1 month ago (2015-11-18 19:44:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459663002/40001
5 years, 1 month ago (2015-11-18 21:18:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/6683)
5 years, 1 month ago (2015-11-18 21:24:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459663002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459663002/60001
5 years, 1 month ago (2015-11-18 21:56:10 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:11:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5aaef1ff1a18b420b3409ec31b44c2435a4ac988

Powered by Google App Engine
This is Rietveld 408576698