Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457123002: Make block size a template parameter of SkTLList (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@forward
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make block size a template parameter of SkTLList Committed: https://skia.googlesource.com/skia/+/f045d600fc5c17f8a3537401baf45043e7617368

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix comparision warnings #

Patch Set 4 : typename #

Patch Set 5 : another missing typename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -202 lines) Patch
M gm/convexpolyclip.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkTLList.h View 1 2 10 chunks +15 lines, -27 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReducedClip.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/LListTest.cpp View 1 2 3 4 2 chunks +157 lines, -157 lines 0 comments Download
M tools/skpdiff/SkDiffContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/skpdiff/SkDiffContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
bsalomon
5 years, 1 month ago (2015-11-18 21:41:34 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1459663002 Patch 40001). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-18 21:42:01 UTC) #5
joshualitt
On 2015/11/18 21:41:34, bsalomon wrote: lgtm
5 years, 1 month ago (2015-11-18 21:43:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457123002/20001
5 years, 1 month ago (2015-11-18 22:17:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4328) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 22:18:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457123002/40001
5 years, 1 month ago (2015-11-18 22:43:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2618) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 22:44:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457123002/60001
5 years, 1 month ago (2015-11-18 22:47:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2619) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 1 month ago (2015-11-18 22:48:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457123002/80001
5 years, 1 month ago (2015-11-19 02:46:10 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:01:15 UTC) #25
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f045d600fc5c17f8a3537401baf45043e7617368

Powered by Google App Engine
This is Rietveld 408576698