Implement the 'noopener' window feature.

Implement the 'noopener' window feature.

This patch enables 'window.open([path], [target], "noopener")' as defined
in step 13 of https://html.spec.whatwg.org/#dom-open. The behavior
matches the 'noopener' link relation which landed in
https://codereview.chromium.org/1443663003.

Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hqW3RGDV8WI/bGe64uK-AQAJ

BUG=551884
Committed: https://crrev.com/a06be427005b97ab47c16e2bd4b6fd6b254c24cc
Cr-Commit-Position: refs/heads/master@{#360643}

[Mike West, 2015-11-18 15:44:39]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2015-11-18 15:44:39]

Mind taking a look at this follow-up to the 'noopener' link relation you
reviewed earlier?

-mike

[jochen (gone - plz use gerrit), 2015-11-18 16:07:59]

lgtm

[Mike West, 2015-11-18 18:49:40]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 18:51:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/1

[commit-bot: I haz the power, 2015-11-18 19:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 19:08:01]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Mike West, 2015-11-19 08:20:02]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 08:21:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/20001

[commit-bot: I haz the power, 2015-11-19 08:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 08:54:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mike West, 2015-11-19 10:37:02]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-11-19 10:37:03]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1459603002/#ps40001
(title: "Test.")

[commit-bot: I haz the power, 2015-11-19 10:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/40001

[commit-bot: I haz the power, 2015-11-19 10:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 10:58:40]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Mike West, 2015-11-19 11:26:48]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-11-19 11:26:48]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1459603002/#ps60001
(title: "Export")

[commit-bot: I haz the power, 2015-11-19 11:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/60001

[commit-bot: I haz the power, 2015-11-19 11:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 11:42:38]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Mike West, 2015-11-19 12:11:33]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-11-19 12:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1459603002/#ps80001
(title: "Ugh.")

[commit-bot: I haz the power, 2015-11-19 12:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/80001

[commit-bot: I haz the power, 2015-11-19 12:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 12:29:31]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Mike West, 2015-11-19 12:59:11]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-11-19 12:59:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/80001

[commit-bot: I haz the power, 2015-11-19 13:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 13:12:51]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[nasko, 2015-11-19 15:06:16]

nasko@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2015-11-19 15:06:16]

Some drive-by comments on the RFHM test.

https://codereview.chromium.org/1459603002/diff/80001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_manager_browsertest.cc
(right):

https://codereview.chromium.org/1459603002/diff/80001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager_browsertest.cc:311:
EXPECT_TRUE(orig_site_instance.get() != NULL);
nullptr

https://codereview.chromium.org/1459603002/diff/80001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager_browsertest.cc:328:
EXPECT_EQ("/title2.html", new_shell->web_contents()->GetVisibleURL().path());
If you move the code around to wait for the navigation completion (as noted
below), this should check GetLastCommittedURL().

https://codereview.chromium.org/1459603002/diff/80001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager_browsertest.cc:337: // Wait
for the cross-site transition in the new tab to finish.
I'd suggest waiting for the navigation to complete first, then check
window.opener. In addition, you can check if the top-level frame has an opener
in the browser process, which should also be null.

[Mike West, 2015-11-19 16:01:15]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-11-19 16:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1459603002/#ps100001
(title: "Nasko")

[commit-bot: I haz the power, 2015-11-19 16:01:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/100001

[commit-bot: I haz the power, 2015-11-19 16:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 16:25:36]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Mike West, 2015-11-19 18:22:52]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-11-19 18:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459603002/100001

[commit-bot: I haz the power, 2015-11-19 19:35:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-19 19:36:56]

Patchset 6 (id:??) landed as
https://crrev.com/a06be427005b97ab47c16e2bd4b6fd6b254c24cc
Cr-Commit-Position: refs/heads/master@{#360643}

[nasko, 2015-11-19 19:46:24]

On 2015/11/19 19:36:56, commit-bot: I haz the power wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/a06be427005b97ab47c16e2bd4b6fd6b254c24cc
> Cr-Commit-Position: refs/heads/master@{#360643}

/me is a sad panda since comments got ignored.

[nasko, 2015-11-19 19:47:20]

On 2015/11/19 19:46:24, nasko wrote:
> On 2015/11/19 19:36:56, commit-bot: I haz the power wrote:
> > Patchset 6 (id:??) landed as
> > https://crrev.com/a06be427005b97ab47c16e2bd4b6fd6b254c24cc
> > Cr-Commit-Position: refs/heads/master@{#360643}
> 
> /me is a sad panda since comments got ignored.

oh, sorry, they were applied, but no email was sent.