Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1443663003: Implement the 'noopener' link relation. (Closed)

Created:
5 years, 1 month ago by Mike West
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the 'noopener' link relation. Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/hqW3RGDV8WI/bGe64uK-AQAJ BUG=551884 Committed: https://crrev.com/a807c1ad89f79e2f98c068ad7fee1cdf23a6f1fd Cr-Commit-Position: refs/heads/master@{#359852}

Patch Set 1 #

Patch Set 2 : browsertest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -18 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 4 chunks +146 lines, -0 lines 0 comments Download
M content/test/data/click-noreferrer-links.html View 1 4 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.h View 1 1 chunk +19 lines, -18 lines 1 comment Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mike West
Would you mind taking a look at this, Jochen? Intent to Ship is in the ...
5 years, 1 month ago (2015-11-13 16:12:55 UTC) #2
Mike West
https://codereview.chromium.org/1443663003/diff/20001/third_party/WebKit/Source/core/html/HTMLAnchorElement.h File third_party/WebKit/Source/core/html/HTMLAnchorElement.h (right): https://codereview.chromium.org/1443663003/diff/20001/third_party/WebKit/Source/core/html/HTMLAnchorElement.h#newcode57 third_party/WebKit/Source/core/html/HTMLAnchorElement.h:57: RelationNoOpener = 0x00040000, `git cl format`.
5 years, 1 month ago (2015-11-15 08:17:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443663003/20001
5 years, 1 month ago (2015-11-16 09:28:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 10:52:50 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-16 12:01:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443663003/20001
5 years, 1 month ago (2015-11-16 16:18:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-16 16:23:03 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:24:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a807c1ad89f79e2f98c068ad7fee1cdf23a6f1fd
Cr-Commit-Position: refs/heads/master@{#359852}

Powered by Google App Engine
This is Rietveld 408576698