Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1459553002: Use invalidation sets for :-webkit-drag. (Closed)

Created:
5 years, 1 month ago by rune
Modified:
5 years, 1 month ago
Reviewers:
tkent, Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets for :-webkit-drag. Gets rid of SubtreeStyleChange which relies on sibling tree recalcs. R=tkent@chromium.org,ericwilligers@chromium.org BUG=557440 Committed: https://crrev.com/ae1d10fe0f86dce0d9fbaa2b9809c0b845bccca3 Cr-Commit-Position: refs/heads/master@{#360465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/DragUpdateTest.cpp View 2 chunks +32 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
rune
ptal
5 years, 1 month ago (2015-11-18 11:48:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459553002/1
5 years, 1 month ago (2015-11-18 11:49:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142408)
5 years, 1 month ago (2015-11-18 12:52:35 UTC) #5
tkent
lgtm
5 years, 1 month ago (2015-11-18 23:31:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459553002/1
5 years, 1 month ago (2015-11-18 23:39:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:41:16 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae1d10fe0f86dce0d9fbaa2b9809c0b845bccca3 Cr-Commit-Position: refs/heads/master@{#360465}
5 years, 1 month ago (2015-11-19 01:42:01 UTC) #10
Eric Willigers
5 years, 1 month ago (2015-11-20 01:38:43 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698