Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: third_party/WebKit/Source/core/css/DragUpdateTest.cpp

Issue 1459553002: Use invalidation sets for :-webkit-drag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/dom/Element.h" 6 #include "core/dom/Element.h"
7 #include "core/dom/StyleEngine.h" 7 #include "core/dom/StyleEngine.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/html/HTMLDocument.h" 9 #include "core/html/HTMLDocument.h"
10 #include "core/html/HTMLElement.h" 10 #include "core/html/HTMLElement.h"
(...skipping 22 matching lines...) Expand all
33 unsigned startCount = document.styleEngine().resolverAccessCount(); 33 unsigned startCount = document.styleEngine().resolverAccessCount();
34 34
35 document.documentElement()->layoutObject()->updateDragState(true); 35 document.documentElement()->layoutObject()->updateDragState(true);
36 document.view()->updateAllLifecyclePhases(); 36 document.view()->updateAllLifecyclePhases();
37 37
38 unsigned accessCount = document.styleEngine().resolverAccessCount() - startC ount; 38 unsigned accessCount = document.styleEngine().resolverAccessCount() - startC ount;
39 39
40 ASSERT_EQ(1U, accessCount); 40 ASSERT_EQ(1U, accessCount);
41 } 41 }
42 42
43 TEST(DragUpdateTest, ChildrenOrSiblingsAffectedByDragUpdate) 43 TEST(DragUpdateTest, ChildAffectedByDragUpdate)
44 { 44 {
45 // Check that when dragging the div in the document below, you get a 45 // Check that when dragging the div in the document below, you get a
46 // full subtree style recalc. 46 // single element style recalc.
47 47
48 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(80 0, 600)); 48 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(80 0, 600));
49 HTMLDocument& document = toHTMLDocument(dummyPageHolder->document()); 49 HTMLDocument& document = toHTMLDocument(dummyPageHolder->document());
50 document.documentElement()->setInnerHTML("<style>div {width:100px;height:100 px} div:-webkit-drag span { background-color: green }</style>" 50 document.documentElement()->setInnerHTML("<style>div {width:100px;height:100 px} div:-webkit-drag .drag { background-color: green }</style>"
51 "<div>" 51 "<div>"
52 "<span></span>" 52 "<span></span>"
53 "<span></span>" 53 "<span></span>"
54 "<span></span>" 54 "<span class='drag'></span>"
55 "<span></span>" 55 "<span></span>"
56 "</div>", ASSERT_NO_EXCEPTION); 56 "</div>", ASSERT_NO_EXCEPTION);
57 57
58 document.updateLayout(); 58 document.updateLayout();
59 unsigned startCount = document.styleEngine().resolverAccessCount(); 59 unsigned startCount = document.styleEngine().resolverAccessCount();
60 60
61 document.documentElement()->layoutObject()->updateDragState(true); 61 document.documentElement()->layoutObject()->updateDragState(true);
62 document.updateLayout(); 62 document.updateLayout();
63 63
64 unsigned accessCount = document.styleEngine().resolverAccessCount() - startC ount; 64 unsigned accessCount = document.styleEngine().resolverAccessCount() - startC ount;
65 65
66 ASSERT_EQ(5U, accessCount); 66 ASSERT_EQ(1U, accessCount);
67 }
68
69 TEST(DragUpdateTest, SiblingAffectedByDragUpdate)
70 {
71 // Check that when dragging the div in the document below, you get a
72 // single element style recalc.
73
74 OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(80 0, 600));
75 HTMLDocument& document = toHTMLDocument(dummyPageHolder->document());
76 document.documentElement()->setInnerHTML("<style>div {width:100px;height:100 px} div:-webkit-drag + .drag { background-color: green }</style>"
77 "<div>"
78 "<span></span>"
79 "<span></span>"
80 "<span></span>"
81 "<span></span>"
82 "</div>"
83 "<span class='drag'></span>", ASSERT_NO_EXCEPTION);
84
85 document.updateLayout();
86 unsigned startCount = document.styleEngine().resolverAccessCount();
87
88 document.documentElement()->layoutObject()->updateDragState(true);
89 document.updateLayout();
90
91 unsigned accessCount = document.styleEngine().resolverAccessCount() - startC ount;
92
93 ASSERT_EQ(1U, accessCount);
67 } 94 }
68 95
69 } // namespace blink 96 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698