Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1459453003: mandoline: write this after lunch. (Closed)

Created:
5 years, 1 month ago by Elliot Glaysher
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, penghuang+watch-mandoline_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo_runner: Get --trace-start working with generic mojo_runner. Android didn't like our magic to automatically include a connection to mojo:tracing in ApplicationImpl. This does things the explicit way: including a mojo:TracingImpl in each and every mojo application package. BUG=534895 Committed: https://crrev.com/8d23e41bbc4bdeebffe51784d483afb95f4be714 Cr-Commit-Position: refs/heads/master@{#360434}

Patch Set 1 #

Patch Set 2 : Add TracingImpls to mus and mash, fix naming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -2 lines) Patch
M components/clipboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/clipboard/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/clipboard/clipboard_application_delegate.h View 3 chunks +4 lines, -0 lines 0 comments Download
M components/clipboard/clipboard_application_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/filesystem/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/filesystem/file_system_app.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/font_service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/font_service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/font_service/font_service_app.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/example/mock_sysui/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/example/mock_sysui/mock_sysui.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/example/mock_sysui/mock_sysui.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/example/views_examples/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/example/views_examples/views_examples_application_delegate.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/example/views_examples/views_examples_application_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/mus_app.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_view/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_view/web_view_application_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/web_view/web_view_application_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/omnibox/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 1 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
sky: review (This also adds some PlatformThread names so that the tracing output is nicer.)
5 years, 1 month ago (2015-11-18 22:05:41 UTC) #3
sky
LGTM
5 years, 1 month ago (2015-11-18 22:13:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459453003/20001
5 years, 1 month ago (2015-11-18 22:22:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-18 22:47:06 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:47:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d23e41bbc4bdeebffe51784d483afb95f4be714
Cr-Commit-Position: refs/heads/master@{#360434}

Powered by Google App Engine
This is Rietveld 408576698