Issue 1459343006: Small tidys GrAtlasTextContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459343006: Small tidys GrAtlasTextContext (Closed)

Created:
5 years, 1 month ago by joshua.litt

Modified:
4 years, 11 months ago

Reviewers:
joshualitt, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@text2

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Small tidys GrAtlasTextContext BUG=skia:

Patch Set 1 #

Patch Set 2 : small tidys #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -38 lines)			Patch
	M	src/gpu/batches/GrAtlasTextBatch.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
	M	src/gpu/batches/GrAtlasTextBatch.cpp	View		12 chunks	+34 lines, -34 lines	2 comments	Download

Depends on Patchset:

Issue 1458233003 Patch 80001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robertphillips

5 years, 1 month ago (2015-11-20 18:43:02 UTC) #3

lgtm + questions

https://codereview.chromium.org/1459343006/diff/20001/src/gpu/batches/GrAtlas...
File src/gpu/batches/GrAtlasTextBatch.cpp (right):

https://codereview.chromium.org/1459343006/diff/20001/src/gpu/batches/GrAtlas...
src/gpu/batches/GrAtlasTextBatch.cpp:342: 
can this be static ?

https://codereview.chromium.org/1459343006/diff/20001/src/gpu/batches/GrAtlas...
src/gpu/batches/GrAtlasTextBatch.cpp:355: 
this guy too ?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages