Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458233003: Factor out GrAtlasTextBatch fromt GrAtlasTextContext (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Factor out GrAtlasTextBatch fromt GrAtlasTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/a751c97e30f988b8d832be6b552a6085d484412d

Patch Set 1 #

Patch Set 2 : remove newline #

Total comments: 1

Patch Set 3 : tweak #

Patch Set 4 : rebase #

Patch Set 5 : linux build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+757 lines, -703 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 14 chunks +19 lines, -700 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/batches/GrAtlasTextBatch.h View 1 2 3 1 chunk +227 lines, -0 lines 0 comments Download
A src/gpu/batches/GrAtlasTextBatch.cpp View 1 2 3 1 chunk +507 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1459343006 Patch 1
Issue 1459343006 Patch 20001

Messages

Total messages: 17 (9 generated)
joshualitt
Just a move and rename
5 years, 1 month ago (2015-11-19 22:20:18 UTC) #2
robertphillips
https://codereview.chromium.org/1458233003/diff/20001/src/gpu/batches/GrAtlasTextBatch.h File src/gpu/batches/GrAtlasTextBatch.h (right): https://codereview.chromium.org/1458233003/diff/20001/src/gpu/batches/GrAtlasTextBatch.h#newcode7 src/gpu/batches/GrAtlasTextBatch.h:7: #ifndef ...
5 years, 1 month ago (2015-11-19 22:24:44 UTC) #3
robertphillips
owise lgtm
5 years, 1 month ago (2015-11-19 22:27:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458233003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458233003/40001
5 years, 1 month ago (2015-11-19 22:32:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2664)
5 years, 1 month ago (2015-11-19 22:33:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458233003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458233003/60001
5 years, 1 month ago (2015-11-19 22:39:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458233003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458233003/80001
5 years, 1 month ago (2015-11-20 14:33:50 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:37:35 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a751c97e30f988b8d832be6b552a6085d484412d

Powered by Google App Engine
This is Rietveld 408576698