Issue 1459343004: RenderFrameDevToolsAgentHost uses new navigation observer API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459343004: RenderFrameDevToolsAgentHost uses new navigation observer API. (Closed)

Created:
5 years, 1 month ago by carlosk

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, telemetry-reviews_chromium.org, devtools-reviews_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

RenderFrameDevToolsAgentHost uses new navigation observer API. This updated RenderFrameDevToolsAgentHost to use the new navigation observer API, a pre-step to making it work with PlzNavigate. Some minor improvements are also included. BUG=551000

Patch Set 1 : #

Patch Set 2 : WIP: RenderFrameHostChanged is no more #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -47 lines)			Patch
M	content/browser/devtools/render_frame_devtools_agent_host.h	View	1	5 chunks	+11 lines, -12 lines	0 comments	Download
M	content/browser/devtools/render_frame_devtools_agent_host.cc	View	1	10 chunks	+56 lines, -34 lines	0 comments	Download
M	content/browser/frame_host/navigation_handle_impl.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tools/perf/page_sets/top_10_mobile.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

carlosk

5 years ago (2015-12-01 11:10:26 UTC) #5

Description was changed from

==========
RenderFrameDevToolsAgentHost uses new navigation observer API.

This updated RenderFrameDevToolsAgentHost to use the new navigation
observer API, a pre-step to making it work with PlzNavigate. Some minor
improvements are also included.

BUG=551000
==========

to

==========
RenderFrameDevToolsAgentHost uses new navigation observer API.

This updated RenderFrameDevToolsAgentHost to use the new navigation
observer API, a pre-step to making it work with PlzNavigate. Some minor
improvements are also included.

BUG=551000
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages