tools/perf/page_sets/top_10_mobile.py - Issue 1459343004: RenderFrameDevToolsAgentHost uses new navigation observer API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/top_10_mobile.py

Issue 1459343004: RenderFrameDevToolsAgentHost uses new navigation observer API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: WIP: RenderFrameHostChanged is no more Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/frame_host/navigation_handle_impl.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.page import page as page_module	4 from telemetry.page import page as page_module

5 from telemetry.page import shared_page_state	5 from telemetry.page import shared_page_state

6 from telemetry import story	6 from telemetry import story

7	7

8	8

9 URL_LIST = [	9 URL_LIST = [

10 # Why: #1 (Alexa) most visited page worldwide, picked a reasonable	10 # Why: #1 (Alexa) most visited page worldwide, picked a reasonable

11 # search term	11 # search term

12 'https://www.google.com/#hl=en&q=science',	12 # 'https://www.google.com/#hl=en&q=science',

13 # Why: #2 (Alexa) most visited page worldwide, picked the most liked	13 # Why: #2 (Alexa) most visited page worldwide, picked the most liked

14 # page	14 # page

15 'https://m.facebook.com/rihanna',	15 'https://m.facebook.com/rihanna',

16 # Why: #3 (Alexa) most visited page worldwide, picked a reasonable	16 # Why: #3 (Alexa) most visited page worldwide, picked a reasonable

17 # search term	17 # search term

18 'http://m.youtube.com/results?q=science',	18 'http://m.youtube.com/results?q=science',

19 # Why: #4 (Alexa) most visited page worldwide, picked a reasonable search	19 # Why: #4 (Alexa) most visited page worldwide, picked a reasonable search

20 # term	20 # term

21 'http://search.yahoo.com/search;_ylt=?p=google',	21 'http://search.yahoo.com/search;_ylt=?p=google',

22 # Why: #5 (Alexa) most visited page worldwide, picked a reasonable search	22 # Why: #5 (Alexa) most visited page worldwide, picked a reasonable search

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59	59

60 """ Top 10 mobile sites """	60 """ Top 10 mobile sites """

61	61

62 def __init__(self, run_no_page_interactions=False):	62 def __init__(self, run_no_page_interactions=False):

63 super(Top10MobilePageSet, self).__init__(	63 super(Top10MobilePageSet, self).__init__(

64 archive_data_file='data/top_10_mobile.json',	64 archive_data_file='data/top_10_mobile.json',

65 cloud_storage_bucket=story.PARTNER_BUCKET)	65 cloud_storage_bucket=story.PARTNER_BUCKET)

66	66

67 for url in URL_LIST:	67 for url in URL_LIST:

68 self.AddStory(Top10MobilePage(url, self, run_no_page_interactions))	68 self.AddStory(Top10MobilePage(url, self, run_no_page_interactions))

OLD	NEW