Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_ui_controller_unittest.cc
diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc
index e2d2bdcd281ed71fe126b5d6c5a7b5d232c85f2c..3c4777c8948ec0b07f2748e14b67c677520e260d 100644
--- a/chrome/browser/download/download_ui_controller_unittest.cc
+++ b/chrome/browser/download/download_ui_controller_unittest.cc
@@ -69,7 +69,7 @@ class DownloadUIControllerTest : public testing::Test {
content::DownloadItem* received_item() { return received_item_; }
private:
- scoped_refptr<MockDownloadManager> manager_;
+ scoped_ptr<MockDownloadManager> manager_;
content::DownloadManager::Observer* manager_observer_;
content::DownloadItem::Observer* item_observer_;
content::DownloadItem* received_item_;
@@ -85,7 +85,7 @@ DownloadUIControllerTest::DownloadUIControllerTest()
}
void DownloadUIControllerTest::SetUp() {
- manager_ = new testing::StrictMock<MockDownloadManager>();
+ manager_.reset(new testing::StrictMock<MockDownloadManager>());
EXPECT_CALL(*manager_, AddObserver(_))
.WillOnce(SaveArg<0>(&manager_observer_));
EXPECT_CALL(*manager_, RemoveObserver(_))

Powered by Google App Engine
This is Rietveld 408576698