Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5612)

Unified Diff: chrome/browser/download/download_shelf_unittest.cc

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_shelf_unittest.cc
diff --git a/chrome/browser/download/download_shelf_unittest.cc b/chrome/browser/download/download_shelf_unittest.cc
index 48045c4d1cea9a3dccc6179a9fd1ab81521cc64b..8b31ffff4e99f83de2457fa16cb0470d7a4e7686 100644
--- a/chrome/browser/download/download_shelf_unittest.cc
+++ b/chrome/browser/download/download_shelf_unittest.cc
@@ -31,7 +31,7 @@ class DownloadShelfTest : public testing::Test {
return download_item_.get();
}
content::MockDownloadManager* download_manager() {
- return download_manager_.get();
+ return download_manager_;
}
TestDownloadShelf* shelf() {
return &shelf_;
@@ -43,7 +43,7 @@ class DownloadShelfTest : public testing::Test {
MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
scoped_ptr<content::MockDownloadItem> download_item_;
- scoped_refptr<content::MockDownloadManager> download_manager_;
+ content::MockDownloadManager* download_manager_;
benjhayden 2013/05/17 14:50:03 Should this be a scoped_ptr?
cmarcelo 2013/05/20 15:22:06 Indeed, thanks.
TestDownloadShelf shelf_;
};
@@ -67,7 +67,7 @@ DownloadShelfTest::DownloadShelfTest()
ON_CALL(*download_manager_, GetDownload(_))
.WillByDefault(Return(download_item_.get()));
- shelf_.set_download_manager(download_manager_.get());
+ shelf_.set_download_manager(download_manager_);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698