chrome/browser/download/download_browsertest.cc - Issue 14593012: BrowserContext should simply own DownloadManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_browsertest.cc

diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc

index 403ba454b4f51217a0cef7b8649a3fd7deade42a..548c5de6d5a47760f027973fda83ae950af7b932 100644

--- a/chrome/browser/download/download_browsertest.cc

+++ b/chrome/browser/download/download_browsertest.cc

@@ -2642,8 +2642,7 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, HiddenDownload) {

base::FilePath file(FILE_PATH_LITERAL("download-test1.lib"));

GURL url(URLRequestMockHTTPJob::GetMockUrl(file));

- scoped_refptr<DownloadManager> download_manager =

- DownloadManagerForBrowser(browser());

+ DownloadManager* download_manager = DownloadManagerForBrowser(browser());

scoped_ptr<content::DownloadTestObserver> observer(

new content::DownloadTestObserverTerminal(

download_manager,