Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java

Issue 14592005: Report CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
index 6e3baa98a047b4832690cf57fba0a1147f880f71..56f0f5cde92888794a9fcbd5040e1a0753a5bb67 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
@@ -718,7 +718,7 @@ public class NonErrorResolverTest extends ResolverTestCase {
public void test_nonVoidReturnForOperator_no() throws Exception {
Source source = addSource(createSource(//
"class A {",
- " operator []=() {}",
+ " operator []=(a, b) {}",
"}"));
resolve(source);
assertNoErrors();
@@ -728,7 +728,7 @@ public class NonErrorResolverTest extends ResolverTestCase {
public void test_nonVoidReturnForOperator_void() throws Exception {
Source source = addSource(createSource(//
"class A {",
- " void operator []=() {}",
+ " void operator []=(a, b) {}",
"}"));
resolve(source);
assertNoErrors();
@@ -989,6 +989,39 @@ public class NonErrorResolverTest extends ResolverTestCase {
assertNoErrors();
}
+ public void test_wrongNumberOfParametersForOperator_index() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " operator []=(a, b) {}",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_wrongNumberOfParametersForOperator_minus() throws Exception {
+ check_wrongNumberOfParametersForOperator("-", "");
+ check_wrongNumberOfParametersForOperator("-", "a");
+ }
+
+ public void test_wrongNumberOfParametersForOperator1() throws Exception {
+ check_wrongNumberOfParametersForOperator1("<");
+ check_wrongNumberOfParametersForOperator1(">");
+ check_wrongNumberOfParametersForOperator1("<=");
+ check_wrongNumberOfParametersForOperator1(">=");
+ check_wrongNumberOfParametersForOperator1("+");
+ check_wrongNumberOfParametersForOperator1("/");
+ check_wrongNumberOfParametersForOperator1("~/");
+ check_wrongNumberOfParametersForOperator1("*");
+ check_wrongNumberOfParametersForOperator1("%");
+ check_wrongNumberOfParametersForOperator1("|");
+ check_wrongNumberOfParametersForOperator1("^");
+ check_wrongNumberOfParametersForOperator1("&");
+ check_wrongNumberOfParametersForOperator1("<<");
+ check_wrongNumberOfParametersForOperator1(">>");
+ check_wrongNumberOfParametersForOperator1("[]");
+ }
+
public void test_wrongNumberOfParametersForSetter() throws Exception {
Source source = addSource(createSource(//
"class A {",
@@ -998,4 +1031,20 @@ public class NonErrorResolverTest extends ResolverTestCase {
assertNoErrors();
verify(source);
}
+
+ private void check_wrongNumberOfParametersForOperator(String name, String parameters)
+ throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " operator " + name + "(" + parameters + ") {}",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ reset();
+ }
+
+ private void check_wrongNumberOfParametersForOperator1(String name) throws Exception {
+ check_wrongNumberOfParametersForOperator(name, "a");
+ }
}

Powered by Google App Engine
This is Rietveld 408576698