Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java

Issue 14592005: Report CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
index 24090c330ac0f38bbc478e6e6602f5117fcfd90e..29d8e93d3e31a4202a0901f49aa1f33be43c3508 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
@@ -533,17 +533,6 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
verify(source);
}
- public void fail_wrongNumberOfParametersForOperator() throws Exception {
- // Do we need _tooMany and _tooFew variants for every operator?
- Source source = addSource(createSource(//
- "class A {",
- " operator []=(i) {}",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR);
- verify(source);
- }
-
public void fail_wrongNumberOfTypeArguments_creation_const_tooFew() throws Exception {
Source source = addSource(createSource(//
"class A {}",
@@ -2075,6 +2064,40 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
// We cannot verify resolution with an unresolvable URI: '${'a'}.dart'
}
+ public void test_wrongNumberOfParametersForOperator_minus() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " operator -(a, b) {}",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR_MINUS);
+ verify(source);
+ reset();
+ }
+
+ public void test_wrongNumberOfParametersForOperator_tilde() throws Exception {
+ check_wrongNumberOfParametersForOperator("~", "a");
+ check_wrongNumberOfParametersForOperator("~", "a, b");
+ }
+
+ public void test_wrongNumberOfParametersForOperator1() throws Exception {
+ check_wrongNumberOfParametersForOperator1("<");
+ check_wrongNumberOfParametersForOperator1(">");
+ check_wrongNumberOfParametersForOperator1("<=");
+ check_wrongNumberOfParametersForOperator1(">=");
+ check_wrongNumberOfParametersForOperator1("+");
+ check_wrongNumberOfParametersForOperator1("/");
+ check_wrongNumberOfParametersForOperator1("~/");
+ check_wrongNumberOfParametersForOperator1("*");
+ check_wrongNumberOfParametersForOperator1("%");
+ check_wrongNumberOfParametersForOperator1("|");
+ check_wrongNumberOfParametersForOperator1("^");
+ check_wrongNumberOfParametersForOperator1("&");
+ check_wrongNumberOfParametersForOperator1("<<");
+ check_wrongNumberOfParametersForOperator1(">>");
+ check_wrongNumberOfParametersForOperator1("[]");
+ }
+
public void test_wrongNumberOfParametersForSetter_function_tooFew() throws Exception {
Source source = addSource("set x() {}");
resolve(source);
@@ -2108,4 +2131,21 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
assertErrors(CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER);
verify(source);
}
+
+ private void check_wrongNumberOfParametersForOperator(String name, String parameters)
+ throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " operator " + name + "(" + parameters + ") {}",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR);
+ verify(source);
+ reset();
+ }
+
+ private void check_wrongNumberOfParametersForOperator1(String name) throws Exception {
+ check_wrongNumberOfParametersForOperator(name, "");
+ check_wrongNumberOfParametersForOperator(name, "a, b");
+ }
}

Powered by Google App Engine
This is Rietveld 408576698