Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 1459133002: Reland "Prepare to enable in-object properties in subclasses on a case by case basis." (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Prepare to enable in-object properties in subclasses on a case by case basis." Original issue's description: > Prepare to enable in-object properties in subclasses on a case by case basis. > > Minor cleanup in VisitorId selection. > > Committed: https://crrev.com/7c449a62edfc03aed84d94da323dcfe2b51a3600 > Cr-Commit-Position: refs/heads/master@{#32030} This is a mostly clean reland. Committed: https://crrev.com/71be4434305a7f2da543d5a4121de269efb4bdb4 Cr-Commit-Position: refs/heads/master@{#32148}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -37 lines) Patch
M src/heap/objects-visiting.cc View 3 chunks +7 lines, -19 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +90 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459133002/40001
5 years, 1 month ago (2015-11-19 18:42:50 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10351)
5 years, 1 month ago (2015-11-19 19:10:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459133002/60001
5 years, 1 month ago (2015-11-20 07:13:04 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 07:50:27 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459133002/80001
5 years, 1 month ago (2015-11-20 11:28:51 UTC) #13
Igor Sheludko
PTAL
5 years, 1 month ago (2015-11-20 11:34:51 UTC) #16
ulan
lgtm
5 years, 1 month ago (2015-11-20 11:43:05 UTC) #18
Toon Verwaest
lgtm with nit https://codereview.chromium.org/1459133002/diff/80001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1459133002/diff/80001/src/objects.cc#newcode11976 src/objects.cc:11976: case JS_PROMISE_TYPE: JS_PROMISE_TYPE can be moved ...
5 years, 1 month ago (2015-11-20 11:52:08 UTC) #19
Igor Sheludko
https://codereview.chromium.org/1459133002/diff/80001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1459133002/diff/80001/src/objects.cc#newcode11976 src/objects.cc:11976: case JS_PROMISE_TYPE: On 2015/11/20 11:52:08, Toon Verwaest wrote: > ...
5 years, 1 month ago (2015-11-20 12:30:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459133002/100001
5 years, 1 month ago (2015-11-20 13:15:40 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 1 month ago (2015-11-20 13:35:17 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 13:35:43 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/71be4434305a7f2da543d5a4121de269efb4bdb4
Cr-Commit-Position: refs/heads/master@{#32148}

Powered by Google App Engine
This is Rietveld 408576698