Fix object initialization when slack tracking for it's map is still enabled.

Fix object initialization when slack tracking for it's map is still enabled.

The old code was not ready for properly initialize objects with non standard headers and non zero in-object properties number.

MacroAssembler::Allocate() implementations now return both start and end addresses of the new object (done by parameter renaming).

Committed: https://crrev.com/2fc2cb99f52974d0743610189213a94585c30ac6
Cr-Commit-Position: refs/heads/master@{#32144}

[Igor Sheludko, 2015-11-19 11:54:13]

Description was changed from

==========
Fix object initialization when slack tracking for it's map is still enabled.

The old code was not ready for properly initialize objects with non standard
headers and non zero in-object properties number.
==========

to

==========
Fix object initialization when slack tracking for it's map is still enabled.

The old code was not ready for properly initialize objects with non standard
headers and non zero in-object properties number.

MacroAssembler::Allocate() implementations now return both start and end
addresses of the new object.
==========

[Igor Sheludko, 2015-11-19 11:55:36]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-11-19 11:55:36]

PTAL. Mips ports are on the way.

[Igor Sheludko, 2015-11-19 11:59:37]

Description was changed from

==========
Fix object initialization when slack tracking for it's map is still enabled.

The old code was not ready for properly initialize objects with non standard
headers and non zero in-object properties number.

MacroAssembler::Allocate() implementations now return both start and end
addresses of the new object.
==========

to

==========
Fix object initialization when slack tracking for it's map is still enabled.

The old code was not ready for properly initialize objects with non standard
headers and non zero in-object properties number.

MacroAssembler::Allocate() implementations now return both start and end
addresses of the new object (done by parameter renaming).
==========

[Igor Sheludko, 2015-11-19 18:26:50]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 18:26:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459083003/60001

[commit-bot: I haz the power, 2015-11-19 18:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 18:53:44]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10349)

[Igor Sheludko, 2015-11-19 23:27:16]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 23:27:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459083003/80001

[commit-bot: I haz the power, 2015-11-20 00:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 00:03:59]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2015-11-20 10:55:55]

lgtm with nit

https://codereview.chromium.org/1459083003/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1459083003/diff/40001/src/objects-inl.h#newco...
src/objects-inl.h:2347: size - (map->unused_property_fields() <<
kPointerSizeLog2);
What about just * kPointerSize? :)

https://codereview.chromium.org/1459083003/diff/80001/src/arm64/macro-assembl...
File src/arm64/macro-assembler-arm64.cc (right):

https://codereview.chromium.org/1459083003/diff/80001/src/arm64/macro-assembl...
src/arm64/macro-assembler-arm64.cc:2382: Stp(filler, filler,
MemOperand(start_address, 2 * kPointerSize, PostIndex));
probably shouldn't call this start_address if it changes ... :)

[Igor Sheludko, 2015-11-20 11:26:15]

https://codereview.chromium.org/1459083003/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1459083003/diff/40001/src/objects-inl.h#newco...
src/objects-inl.h:2347: size - (map->unused_property_fields() <<
kPointerSizeLog2);
On 2015/11/20 10:55:55, Toon Verwaest wrote:
> What about just * kPointerSize? :)

Done.

https://codereview.chromium.org/1459083003/diff/80001/src/arm64/macro-assembl...
File src/arm64/macro-assembler-arm64.cc (right):

https://codereview.chromium.org/1459083003/diff/80001/src/arm64/macro-assembl...
src/arm64/macro-assembler-arm64.cc:2382: Stp(filler, filler,
MemOperand(start_address, 2 * kPointerSize, PostIndex));
On 2015/11/20 10:55:55, Toon Verwaest wrote:
> probably shouldn't call this start_address if it changes ... :)

That was a common naming convention. Fixed on all platforms.

[Igor Sheludko, 2015-11-20 11:26:44]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-20 11:26:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459083003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459083003/140001

[Igor Sheludko, 2015-11-20 11:57:26]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2015-11-20 11:58:01]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-11-20 11:58:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1459083003/#ps140001
(title: "Fixed second nit in all platforms")

[commit-bot: I haz the power, 2015-11-20 11:58:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459083003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459083003/140001

[commit-bot: I haz the power, 2015-11-20 12:04:10]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-11-20 12:04:40]

Patchset 8 (id:??) landed as
https://crrev.com/2fc2cb99f52974d0743610189213a94585c30ac6
Cr-Commit-Position: refs/heads/master@{#32144}