Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6946)

Unified Diff: chrome/test/chromedriver/chrome/performance_logger.h

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Rewrite ConsoleLogger::OnEvent from stringstream to printf. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/performance_logger.h
diff --git a/chrome/test/chromedriver/chrome/performance_logger.h b/chrome/test/chromedriver/chrome/performance_logger.h
index 64ee85a56540541c079b7ef03552508080ffe4e4..46f8b2b603a4e33039e19165c89f9e566edef15e 100644
--- a/chrome/test/chromedriver/chrome/performance_logger.h
+++ b/chrome/test/chromedriver/chrome/performance_logger.h
@@ -20,15 +20,19 @@ class Log;
// }
class PerformanceLogger : public DevToolsEventListener {
public:
+ // Creates a PerformanceLogger that creates entries in the given Log object.
+ // The log is owned elsewhere and must not be NULL.
jdennett 2013/05/23 03:44:24 s/NULL/null/
klm 2013/05/23 15:21:39 Done.
explicit PerformanceLogger(Log* log);
+ // Enables Page,Network,Timeline events for client, which must not be NULL.
virtual Status OnConnected(DevToolsClient* client) OVERRIDE;
+ // Translates an event into a log entry.
virtual void OnEvent(DevToolsClient* client,
const std::string& method,
const base::DictionaryValue& params) OVERRIDE;
private:
- Log* log_;
+ Log* log_; // The log where to create entries.
DISALLOW_COPY_AND_ASSIGN(PerformanceLogger);
};

Powered by Google App Engine
This is Rietveld 408576698