chrome/test/chromedriver/chrome/performance_logger.cc - Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/performance_logger.cc

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Rewrite ConsoleLogger::OnEvent from stringstream to printf. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/performance_logger.h ('K') | « chrome/test/chromedriver/chrome/performance_logger.h ('k') | chrome/test/chromedriver/chrome/performance_logger_unittest.cc » ('j') | chrome/test/chromedriver/chrome/performance_logger_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/performance_logger.cc

diff --git a/chrome/test/chromedriver/chrome/performance_logger.cc b/chrome/test/chromedriver/chrome/performance_logger.cc

index d144870ea7c9d23973c811635e50956c2acb96cd..509acc34dd7d1e17bd872f6ccc4d0ae4e0290a35 100644

--- a/chrome/test/chromedriver/chrome/performance_logger.cc

+++ b/chrome/test/chromedriver/chrome/performance_logger.cc

@@ -14,9 +14,9 @@

namespace {

// DevTools event domain prefixes to intercept.

-const char* kDomains[] = {"Network.", "Page.", "Timeline."};

+const char* const kDomains[] = {"Network.", "Page.", "Timeline."};

-const char* kDomainEnableCommands[] = {

+const char* const kDomainEnableCommands[] = {

"Network.enable", "Page.enable", "Timeline.start"

};