Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2266)

Issue 1459043003: Revert "Replaced blink sync points with new sync tokens." (Closed)

Created:
5 years, 1 month ago by David Yen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, dshwang, sievers+watch_chromium.org, mlamouri+watch-media_chromium.org, rwlbuis, danakj, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, jam, Justin Novosad, jbauman+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, blink-reviews, kalyank, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, vmpstr+blinkwatch_chromium.org, jbroman, feature-media-reviews_chromium.org, krit, piman+watch_chromium.org, Stephen Chennney, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, ajuma+watch-canvas_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, f(malita), mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Replaced blink sync points with new sync tokens." This reverts commit 60af6a5108d5bfb1b1eeb64fb1881097a889d70a. Reverting previous CL because it was causing bot failures. Replaced blink sync points with new sync tokens. Original Issue's description: > BUG=514815 > Committed: https://crrev.com/60af6a5108d5bfb1b1eeb64fb1881097a889d70a > Cr-Commit-Position: refs/heads/master@{#360442} BUG=514815 TBR=piman@chromium.org, haraken@chromium.org, jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/08cf4e42f8078a9a4104205811b891069f2fb3d3 Cr-Commit-Position: refs/heads/master@{#360512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -85 lines) Patch
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/common/gpu/client/gpu_context_tests.h View 2 chunks +7 lines, -24 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 5 chunks +7 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 4 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459043003/1
5 years, 1 month ago (2015-11-19 03:15:54 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-19 03:15:55 UTC) #7
David Yen
Reverting my blink sync point CL, causing bot failures
5 years, 1 month ago (2015-11-19 03:18:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459043003/1
5 years, 1 month ago (2015-11-19 03:19:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 03:20:52 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 03:21:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08cf4e42f8078a9a4104205811b891069f2fb3d3
Cr-Commit-Position: refs/heads/master@{#360512}

Powered by Google App Engine
This is Rietveld 408576698